Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add patch to MPFR version (#23287)" #25022

Merged
merged 1 commit into from
Dec 13, 2017
Merged

Revert "Add patch to MPFR version (#23287)" #25022

merged 1 commit into from
Dec 13, 2017

Conversation

yuyichao
Copy link
Contributor

This reverts commit 8f5f981.

  1. The function is not unnecessary

  2. The patch field of VersionNumber is not what this is meant for

    Note that the function name is patches not patch and it is

    a null-terminated string containing the ids of the patches
    applied to the MPFR library (contents of the PATCHES file),
    separated by spaces

    As defined by the MPFR doc.

In particular, it may not be a valid version string and must not be part of it.

@yuyichao
Revert "Add patch to MPFR version (#23287)"
0937ba0 
This reverts commit 8f5f981.

1. The function is not unnecessary
2. The patch field of VersionNumber is not what this is meant for

    Note that the function name is `patches` not `patch` and it is

    > a null-terminated string containing the ids of the patches
    > applied to the MPFR library (contents of the PATCHES file),
    > separated by spaces

    As defined by the MPFR doc.

In particular, it may not be a valid version string
and must not be part of it.
@yuyichao yuyichao added the bugfix This change fixes an existing bug label Dec 11, 2017
@simonbyrne
Copy link
Contributor

Link to #23287.

I honestly don't care. Let's just merge #24924.

@yuyichao
Copy link
Contributor Author

Link to #23287.

It's in the title and commit message......

I honestly don't care. Let's just merge #24924.

Sure, but it's not related to this change. It merely remove the test case.

@yuyichao yuyichao merged commit 87c1d4f into master Dec 13, 2017
@yuyichao yuyichao deleted the yyc/mpfr-nopatch branch December 13, 2017 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuyichao @simonbyrne