Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do we need broadcast_function? #16601

Closed
JeffBezanson opened this issue May 26, 2016 · 3 comments · Fixed by #16613
Closed

do we need broadcast_function? #16601

JeffBezanson opened this issue May 26, 2016 · 3 comments · Fixed by #16613

Comments

@JeffBezanson
Copy link
Member

I came across this looking for exports to remove. It just does (As...) -> broadcast(f, As...), so I'm not sure we need an exported function for this. Is this widely used?

@StefanKarpinski
Copy link
Member

Yeah, that seems pretty unnecessary.

@timholy
Copy link
Member

timholy commented May 26, 2016

Out of 218 installed packages on my laptop, grep can't find a single use.

@toivoh
Copy link
Contributor

toivoh commented May 26, 2016

I introduced it with the original broadcast to allow you to get hold of the appropriate broadcasted function directly instead of having to go through a dict lookup each time you wanted to broadcast the same function. But I think it has degenerated since, and now that we have specialization on function arguments I guess it's not needed at all anymore. (Haven't looked into how the current broadcast implementation handles this.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants