Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate broadcast_function and broadcast!_function #16613

Merged
merged 1 commit into from
May 28, 2016
Merged

Conversation

JeffBezanson
Copy link
Member

closes #16601

@tkelman
Copy link
Contributor

tkelman commented May 27, 2016

Do you use ack or something configured in a way that skips contrib?

@JeffBezanson
Copy link
Member Author

Yes. Also I don't think it makes sense for an editor mode to contain a list of Base exports. Can we remove them so we don't have to keep "maintaining" the list? Only this one editor mode has the list, none of the others do AFAIK. I don't think there is a good reason to color those functions differently. They also seem to be classified as "keywords" along with actual keywords like for, while, etc. so I would say the file is just wrong.

@StefanKarpinski
Copy link
Member

I agree with getting rid of the export lists in various editor modes – functions are just functions. For what it's worth, a good way to search for a pattern in the whole project is

git ls-files [<dirs>...] | xargs ack <pattern>

@tkelman
Copy link
Contributor

tkelman commented May 27, 2016

@cormullion seems to be the main author (and presumably, user?) of that file, so ask him? I would of course prefer if these things were all completely autogenerated, and hosted in external repos (JuliaEditorSupport org?). The other editor support files that are still in contrib have lists of some types and functions, but not all exports like that one.

@JeffBezanson
Copy link
Member Author

The fact that Base functions are in the same category as if, while etc. in that file definitely seems like a bug to me.

@cormullion
Copy link
Contributor

I confess and hang my head in a modest amount of shame: I did stick everything into that BBEdit plist file... More recently I've been using Vim and Atom, and I wasn't intending to keep updating the BBEdit plist file for every future release or writing a script to generate one either. I'd support you removing it now, and if anyone wants to hack on a copy they can shout on the discussion forums...

@tkelman
Copy link
Contributor

tkelman commented May 27, 2016

Thanks for responding. Will give people a bit of time to speak up at https://groups.google.com/forum/?nomobile=true#!topic/julia-users/sQ5Atvjicxw, we'll either delete it or move it to its own repo.

@tkelman tkelman merged commit 6591216 into master May 28, 2016
@tkelman tkelman deleted the jb/dep_bcast_fun branch May 28, 2016 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

do we need broadcast_function?
4 participants