Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecation of @unix_only etc. to NEWS #18189

Closed
dpsanders opened this issue Aug 22, 2016 · 2 comments · Fixed by #18254
Closed

Add deprecation of @unix_only etc. to NEWS #18189

dpsanders opened this issue Aug 22, 2016 · 2 comments · Fixed by #18254
Labels
docs This change adds or pertains to documentation good first issue Indicates a good issue for first-time contributors to Julia
Milestone
0.5.0

Comments

@dpsanders
Copy link
Contributor

The deprecation of @unix_only, @osx etc., should be added to NEWS.md.
@kshyatt kshyatt added docs This change adds or pertains to documentation good first issue Indicates a good issue for first-time contributors to Julia labels Aug 22, 2016
@StefanKarpinski StefanKarpinski added the needs news A NEWS entry is required for this change label Aug 23, 2016
@StefanKarpinski StefanKarpinski added this to the 0.5.0 milestone Aug 23, 2016
BrandonEdwards added a commit to BrandonEdwards/julia that referenced this issue Aug 26, 2016
@BrandonEdwards
Fix JuliaLang#18189 (Add deprecation of etc. to NEWS)
e390936
@BrandonEdwards BrandonEdwards mentioned this issue Aug 26, 2016
Merged
@PallHaraldsson
Copy link
Contributor

PallHaraldsson commented Aug 26, 2016 •
edited
Loading

#18255 ok? Hmm, @bedwards144 you beat me too it.. Your #18189 version wasn't here minutes ago when I started.. Maybe your version is better.. or combine. Feel free to merge versions.

@PallHaraldsson
Copy link
Contributor

PallHaraldsson commented Aug 27, 2016 •
edited
Loading

This seems to be good to go (better than other guys version?). I didn't change wording elsewhere in NEWS: "The @windows_only and @osx family of macros" that was already in.. not asked for, could be separate if needed.

@PallHaraldsson PallHaraldsson mentioned this issue Aug 27, 2016
Closed
tkelman pushed a commit that referenced this issue Sep 2, 2016
@BrandonEdwards @tkelman
Fix #18189 (Add deprecation of @unix_only, etc. to NEWS) (#18254)
1af52d0 
* Fix #18189 (Add deprecation of  etc. to NEWS)

* Remove mentioning of @static, add as a note

* Added reference to Handling Operating System Variation section in manual

* Changed reference numbers

* Change PR number
mfasi pushed a commit to mfasi/julia that referenced this issue Sep 5, 2016
@BrandonEdwards @mfasi
Fix JuliaLang#18189 (Add deprecation of @unix_only, etc. to NEWS) (Ju…
b900734 
…liaLang#18254)

* Fix JuliaLang#18189 (Add deprecation of  etc. to NEWS)

* Remove mentioning of @static, add as a note

* Added reference to Handling Operating System Variation section in manual

* Changed reference numbers

* Change PR number
tkelman pushed a commit that referenced this issue Sep 6, 2016
@BrandonEdwards @tkelman
Fix #18189 (Add deprecation of @unix_only, etc. to NEWS) (#18254)
2274a88 
* Fix #18189 (Add deprecation of  etc. to NEWS)

* Remove mentioning of @static, add as a note

* Added reference to Handling Operating System Variation section in manual

* Changed reference numbers

* Change PR number

(cherry picked from commit 1af52d0)
@Sacha0 Sacha0 removed the needs news A NEWS entry is required for this change label May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs This change adds or pertains to documentation good first issue Indicates a good issue for first-time contributors to Julia
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Fix #18189 (Add deprecation of @unix_only, etc. to NEWS) BrandonEdwards/julia
5 participants
@StefanKarpinski @dpsanders @kshyatt @Sacha0 @PallHaraldsson