Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #18189 (Add deprecation of @unix_only, etc. to NEWS) #18254

Merged
merged 8 commits into from
Sep 2, 2016

Conversation

BrandonEdwards
Copy link
Contributor

fixes #18189

@PallHaraldsson
Copy link
Contributor

See also #18189 (comment)

* `@windows_only` is deprecated in favor of `@static if is_windows()`
* `@unix_only` is deprecated in favor of `@static if is_unix()`
* `@osx_only` is deprecated in favor of `@static if is_apple()`
* `@linux_only` is deprecated in favor of `@static if is_linux()`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These shouldn't mention @static, Mentioning that using @static could be useful/necessary when used in a function's local scope at the end is ok.

@BrandonEdwards
Copy link
Contributor Author

I've updated it and added a note about using @static.

@tkelman tkelman added docs This change adds or pertains to documentation backport pending 0.5 labels Aug 28, 2016
@@ -478,6 +478,17 @@ Deprecated or removed
* The no-op `transpose` fallback has been deprecated. Consider introducing suitable
`transpose` methods or calling `permutedims(x, [2,1])` ([#13171], [#17075], [#17374]).

* The following macros have been deprecated ([#18189]):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

18189 is not the right reference, it should refer to when the actual change was made

@ViralBShah
Copy link
Member

@@ -478,6 +478,17 @@ Deprecated or removed
* The no-op `transpose` fallback has been deprecated. Consider introducing suitable
`transpose` methods or calling `permutedims(x, [2,1])` ([#13171], [#17075], [#17374]).

* The following macros have been deprecated ([#6674] and [#4233]):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use the actual PR number

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be the PR number of this PR, or the one where the macros were actually deprecated? Sorry, this is my first ever PR to anything open source, still learning my way around a bit!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the pr where the macros were deprecated. no worries, questions are encouraged.

@tkelman tkelman merged commit 1af52d0 into JuliaLang:master Sep 2, 2016
@tkelman
Copy link
Contributor

tkelman commented Sep 2, 2016

Thanks @bedwards144!

mfasi pushed a commit to mfasi/julia that referenced this pull request Sep 5, 2016
…liaLang#18254)

* Fix JuliaLang#18189 (Add deprecation of  etc. to NEWS)

* Remove mentioning of @static, add as a note

* Added reference to Handling Operating System Variation section in manual

* Changed reference numbers

* Change PR number
tkelman pushed a commit that referenced this pull request Sep 6, 2016
* Fix #18189 (Add deprecation of  etc. to NEWS)

* Remove mentioning of @static, add as a note

* Added reference to Handling Operating System Variation section in manual

* Changed reference numbers

* Change PR number

(cherry picked from commit 1af52d0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add deprecation of @unix_only etc. to NEWS
5 participants