EnvHash should be immutable and be called EnvDict #24167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, renaming |
This is a bit of a relic, and was never really updated to be a standard immutable singleton. I doubt there is a lot of practical difference, but hey. FYI this type so old, it is now the *second* time it is called a `struct`. :)
andyferris
force-pushed
the
ajf/immutable-envhash
branch
from
c6f7ed0 to
d543862
Compare
|
I used find-and-replace to change to |
andyferris
force-pushed
the
ajf/immutable-envhash
branch
from
d543862 to
4479185
Compare
andyferris
force-pushed
the
ajf/immutable-envhash
branch
from
4479185 to
f9217a7
Compare
andyferris
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a relic, and was never really updated to be a standard immutable singleton. I doubt there is a lot of practical difference, but hey.
FYI this type so old, it is now the second time it is called a
struct. :)(If we really want to modernize this thing before v1.0, maybe "Hash" is a poor term - "Dict" and "Associative" seem more relevant.
EnvDict?)