Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@isdefined with the new optimizer #27103

Closed
fredrikekre opened this issue May 15, 2018 · 0 comments
Closed

@isdefined with the new optimizer #27103

fredrikekre opened this issue May 15, 2018 · 0 comments
Assignees
@Keno
Labels
compiler:optimizer Optimization passes (mostly in base/compiler/ssair/) needs tests Unit tests are required for this change regression Regression in behavior compared to a previous version

Comments

@fredrikekre
Copy link
Member

The following example from the documentation, used to print false, true, but started failing when the new optimizer was enabled by default (#27087)

julia> function f()
           println(@isdefined x)
           x = 3
           println(@isdefined x)
       end
f (generic function with 1 method)

julia> f()
false
false
@fredrikekre fredrikekre added the compiler:optimizer Optimization passes (mostly in base/compiler/ssair/) label May 15, 2018
@fredrikekre fredrikekre mentioned this issue May 15, 2018
Merged
@JeffBezanson JeffBezanson added regression Regression in behavior compared to a previous version needs tests Unit tests are required for this change labels May 15, 2018
fredrikekre added a commit that referenced this issue May 17, 2018
@fredrikekre
temporarily disable at-isdefined doctest (JuliaLang/julia/#27103)
f6ba7e2
fredrikekre added a commit that referenced this issue May 17, 2018
@fredrikekre
fix remaining doctest failures and enable doctests on CI (#27000)
406615f 
* fix all remaining doctest failures

* run doctest on Travis Linux x86_64, fix #19528

* temporarily disable at-isdefined doctest (JuliaLang/julia/#27103)
Keno added a commit that referenced this issue May 18, 2018
@Keno
Fix @isdefined with new optimizer
121ca8a 
The only values that are special for an `:isdefined` expression are SSAValues
(which are tracked through to phi nodes to see if they are defined), global
variables and static parameters (both of which have support in the interpreter
and codegen).

Fixes #27103.
Keno added a commit that referenced this issue May 18, 2018
@Keno
Fix @isdefined with new optimizer
52470fb 
The only values that are special for an `:isdefined` expression are SSAValues
(which are tracked through to phi nodes to see if they are defined), global
variables and static parameters (both of which have support in the interpreter
and codegen).

Fixes #27103.
@Keno Keno mentioned this issue May 18, 2018
Merged
Keno added a commit that referenced this issue May 18, 2018
@Keno
Fix @isdefined with new optimizer
c3d27d9 
The only values that are special for an `:isdefined` expression are SSAValues
(which are tracked through to phi nodes to see if they are defined), global
variables and static parameters (both of which have support in the interpreter
and codegen).

Fixes #27103.
staticfloat pushed a commit that referenced this issue May 20, 2018
@Keno @staticfloat
Fix @isdefined with new optimizer
6a77637 
The only values that are special for an `:isdefined` expression are SSAValues
(which are tracked through to phi nodes to see if they are defined), global
variables and static parameters (both of which have support in the interpreter
and codegen).

Fixes #27103.
staticfloat pushed a commit that referenced this issue May 21, 2018
@Keno @staticfloat
Fix @isdefined with new optimizer
3403939 
The only values that are special for an `:isdefined` expression are SSAValues
(which are tracked through to phi nodes to see if they are defined), global
variables and static parameters (both of which have support in the interpreter
and codegen).

Fixes #27103.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Keno Keno

Labels
compiler:optimizer Optimization passes (mostly in base/compiler/ssair/) needs tests Unit tests are required for this change regression Regression in behavior compared to a previous version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JeffBezanson @Keno @fredrikekre