-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrong permutation for rook-pivoted Bunch–Kaufman #32080
Labels
domain:linear algebra
Linear algebra
kind:bug
Indicates an unexpected problem or unintended behavior
Comments
stevengj
added
kind:bug
Indicates an unexpected problem or unintended behavior
domain:linear algebra
Linear algebra
labels
May 19, 2019
A corrected permutation was posted here: https://discourse.julialang.org/t/bunch-kaufman-with-rook-pivoting/24379/4 by @RalphAS |
timholy
added a commit
that referenced
this issue
May 22, 2019
KristofferC
pushed a commit
that referenced
this issue
May 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
domain:linear algebra
Linear algebra
kind:bug
Indicates an unexpected problem or unintended behavior
#14389 by @timholy added support for rook-pivoted Bunch–Kaufman factorization, but it seems like the permutation (
p
orP
) property should have been updated. As reported on discourse, it looks like the wrong permutation. For example:gives
false
. The permutationB.p == [1,3,2]
, whereas it seems that the correct permuation is[2,1,3]
in this case.#14389 did not change the
_ipiv2perm_bk
routine that computes the permutation fromipiv
, but the documentation forsytrf_rook
seems to indicate that itsipiv
array has a different meaning than that ofsytrf
.The text was updated successfully, but these errors were encountered: