Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong permutation for rook-pivoted Bunch–Kaufman #32080

Closed
stevengj opened this issue May 19, 2019 · 1 comment
Closed

wrong permutation for rook-pivoted Bunch–Kaufman #32080

stevengj opened this issue May 19, 2019 · 1 comment
Labels
domain:linear algebra Linear algebra kind:bug Indicates an unexpected problem or unintended behavior

Comments

@stevengj
Copy link
Member

#14389 by @timholy added support for rook-pivoted Bunch–Kaufman factorization, but it seems like the permutation (p or P) property should have been updated. As reported on discourse, it looks like the wrong permutation. For example:

A = Symmetric([-5 -9 9; -9 4 1; 9 1 2])
B = bunchkaufman(A, true)
B.U * B.D * B.U' ≈ A[B.p, B.p]

gives false. The permutation B.p == [1,3,2], whereas it seems that the correct permuation is [2,1,3] in this case.

#14389 did not change the _ipiv2perm_bk routine that computes the permutation from ipiv, but the documentation for sytrf_rook seems to indicate that its ipiv array has a different meaning than that of sytrf.

@stevengj stevengj added kind:bug Indicates an unexpected problem or unintended behavior domain:linear algebra Linear algebra labels May 19, 2019
@stevengj
Copy link
Member Author

stevengj commented May 20, 2019

A corrected permutation was posted here: https://discourse.julialang.org/t/bunch-kaufman-with-rook-pivoting/24379/4 by @RalphAS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:linear algebra Linear algebra kind:bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

1 participant