Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug-report=rr pollutes the user's environment #40398

Closed
GlenHertz opened this issue Apr 8, 2021 · 3 comments
Closed

bug-report=rr pollutes the user's environment #40398

GlenHertz opened this issue Apr 8, 2021 · 3 comments
Assignees

Comments

@GlenHertz
Copy link
Contributor

When running julia 1.6.0 on Linux like:

julia --bug-report=rr --project=@. runtests.jl

It will modify the project's environment:

[ Info: Loading BugReporting package...
[ Info: Package `BugReporting` not found - attempting temporary installation
    Updating registry at `~/.julia/registries/General`
    Updating git-repo `https://github.com/JuliaRegistries/General`
   Resolving package versions...
    Updating `~/JC/pkgs/MyProject.jl/Project.toml`
  [bcf9a6e7] + BugReporting v0.1.3
    Updating `~/JC/pkgs/SPICEFrontend.jl/Manifest.toml`
  [4f1ea46c] + AWSCore v0.6.17
  [1c724243] + AWSS3 v0.6.12
  [bcf9a6e7] + BugReporting v0.1.3
...

while it should create a temporary environment and not modify the user's project environment.

@Keno
Copy link
Member

Keno commented Apr 8, 2021

I originally had a Pkg.activate here to avoid this, but looks like that got dropped in 43d8a28 (cc @fredrikekre). @fredrikekre can you suggest a fix?

@fredrikekre fredrikekre self-assigned this Apr 8, 2021
@fredrikekre
Copy link
Member

I believe it was correct after 43d8a28 but 6d3ff11#diff-b5a3d517bf443d59c5cfe08a30886d887e477b9681c91ffdf258a8e8229266bc removed some logic there.

@fredrikekre
Copy link
Member

Should be fixed by #40403, but note that BugReporting does not respect the --project flag (but that should be fixed in that package).

@vtjnash vtjnash closed this as completed in f021c67 Apr 8, 2021
KristofferC pushed a commit that referenced this issue Apr 11, 2021
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this issue May 4, 2021
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this issue May 9, 2021
johanmon pushed a commit to johanmon/julia that referenced this issue Jul 5, 2021
staticfloat pushed a commit that referenced this issue Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants