Backports release 1.6.1 #40209
Merged
Backports release 1.6.1 #40209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
force-pushed
the
backports-release-1.6
branch
from
d671804 to
e4b20c0
Compare
KristofferC
force-pushed
the
backports-release-1.6
branch
from
083e9d8 to
40f0ecd
Compare
(cherry picked from commit cc4690a)
* Fix #38491: fix an abspath() edge case on Windows * Update base/path.jl Co-authored-by: Jameson Nash <vtjnash@gmail.com> * Update base/path.jl * Update test/path.jl Co-authored-by: Jameson Nash <vtjnash@gmail.com> Co-authored-by: Mustafa M <mus-m@outlook.com> Co-authored-by: Jameson Nash <vtjnash@gmail.com> (cherry picked from commit f023677)
…40163) * Have different Windows uninstall keys for different Julia versions Should fix #40004. Have the uninstall key to be "{#AppNameLong}_is1" where AppNameLong contains the Julia version to prevent Windows from overwriting the uninstall information for different Julia versions. Inno Setup documentation about the AppId https://jrsoftware.org/ishelp/topic_setup_appid.htm copied here for convenience ``` [Setup]: AppId Default value: AppName Description: The value of AppId is stored inside uninstall log files (unins???.dat), and is checked by subsequent installations to determine whether it may append to a particular existing uninstall log. Setup will only append to an uninstall log if the AppId of the existing uninstall log is the same as the current installation's AppId. For a practical example, say you have two installations -- one entitled My Program and the other entitled My Program 1.1 Update. To get My Program 1.1 Update to append to My Program's uninstall log, you would have to set AppId to the same value in both installations. AppId also determines the actual name of the Uninstall registry key, to which Inno Setup tacks on "_is1" at the end. (Therefore, if AppId is "MyProgram", the key will be named "MyProgram_is1".) Pre-1.3 versions of Inno Setup based the key name on the value of AppVerName. AppId is a not used for display anywhere, so feel free to make it as cryptic as you desire. The value may include constants. If you use a {code:..} constant to allow your user to customize AppId, you do not need to return the real value until just before the installation starts: if necessary you may return an empty or generic value at earlier times. If not empty, this value will only be used to attempt to restore previous install settings (like the settings stored by [Setup] section directive UsePreviousAppDir). If empty, it isn't used for anything. The length of AppId with all constants evaluated should never exceed 127 characters. Example: AppId=MyProgram ``` * Use DirName as AppId Co-authored-by: Mustafa M <mus-m@outlook.com> * remove unneeded code Co-authored-by: Mustafa M <mus-m@outlook.com> (cherry picked from commit e2f5f26)
We copy-pasted the wrong macro here, should have used `CNAMEADDR()` not `CNAME()`. This causes segfaults on armv7l processors by trying to read from an incorrect address when loading the trampoline target address value. (cherry picked from commit 1897e08)
(cherry picked from commit c6d5c40)
(cherry picked from commit 0f828a2)
(cherry picked from commit 42766ac)
(cherry picked from commit 8868d3f)
* add a missing propagate_inbounds (cherry picked from commit 80002db)
Fixes #40303. When printing values to fixed widths through the `Ryu.writefixed` or `Ryu.writeexp` routines, we have a "cleanup" section after a value has been printed to see if it needs to be rounded given the input precision and width. The core issue was the terminating condition: it previously only checked if we were at the start of a buffer or had encountered the `'-'` character. Via Printf formatting, however, it also allows specifying the `'+'` and `' '` characters to preceed a formatted number. Hence, in the OP, the `'1'` character was getting "rounded" up to the `','` character. The fix here is correctly checking if the `plus` or `space` options were passed to the routine and if so, include those in our rounding termination check. The original issue only reported the "plus" case for the `f` format specifier, but the same bug affects the `e` format specifier and the "space" option. (cherry picked from commit fcf6779)
* Fix relpath when path and startpath are in the same drive When startpath == ".", assume the startpath is in the same drive. This subsequently required tweaking the existing logic to then canonicalize the drive casing in instances where the drive casing differs. (cherry picked from commit 89fff18)
(cherry picked from commit a52b43d)
(cherry picked from commit 73aa7e4)
(cherry picked from commit c889de7)
* fix #40258: nested string interpolation fixes #40258 * fix interpolation with varargs * add additional test case * add additional test cases Co-authored-by: Nathan Daly <NHDaly@gmail.com> * keep previous behavior, don't try to be too smart Co-authored-by: Nathan Daly <NHDaly@gmail.com> Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com> (cherry picked from commit 637f52b)
(cherry picked from commit 0d9163b)
(cherry picked from commit 5332d7d)
KristofferC
force-pushed
the
backports-release-1.6
branch
from
40f0ecd to
73bdd12
Compare
* [build] Add `symlink_system_library` calls for CSL We differentiate between a `USE_BINARYBUILDER_CSL=0` configuration (where we copy the CSL libraries into the Julia build tree) versus a `USE_SYSTEM_CSL=1` configuration (where we symlink them in a manner similar to other system libararies) * Expand `JL_PRIVATE_LIBS-1` for versioned library names as well Without this, we fail to install things like `libgcc_s.so.1` when installed into the private libdir by `symlink_system_libraries`. (cherry picked from commit 336cdf8)
* fix a typo in TOML error message (cherry picked from commit e260f2b)
(cherry picked from commit 454fc51)
This avoids computing `length` unnecessarily, which often requires a division, and is therefore often expensive. (cherry picked from commit 40d4f4a)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@nanosoldier |
|
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt |
|
@nanosoldier |
|
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt |
Co-authored-by: Dilum Aluthge <dilum@aluthge.com> (cherry picked from commit 2f0156a)
|
AxisKeys is mcabbott/AxisKeys.jl#57. MadNLP passes locally. I'll update JuliaInterpreter. |
|
@nanosoldier |
|
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt |
|
@nanosoldier |
|
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt |
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @christopher-dG |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported PRs:
@nospecialize(::T)#40293 - fix macro hygiene for@nospecialize(::T)reducetype inference on 1.6 #40277)symlink_system_librarycalls for CSL #40217 - [build] Addsymlink_system_librarycalls for CSLtypeof(NULL)for some union tags #40365 - fix codegen emitsjl_typeof(NULL)(which obviously segfaults) #32843, codegen attemptingtypeof(NULL)for some union tagsNon-merged PRs with backport label: