Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix armv7l trampoline #40176

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Fix armv7l trampoline #40176

merged 1 commit into from
Mar 25, 2021

Conversation

staticfloat
Copy link
Member

We copy-pasted the wrong macro here, should have used CNAMEADDR() not CNAME(). This causes segfaults on armv7l processors by trying to read from an incorrect address when loading the trampoline target address value.

Fixes #39293

We copy-pasted the wrong macro here, should have used `CNAMEADDR()` not `CNAME()`.  This causes segfaults on armv7l processors by trying to read from an incorrect address when loading the trampoline target address value.
@staticfloat staticfloat added system:arm ARMv7 and AArch64 backport 1.6 Change should be backported to release-1.6 labels Mar 24, 2021
@staticfloat staticfloat merged commit 1897e08 into master Mar 25, 2021
@staticfloat staticfloat deleted the sf/arm32_trampoline_fix branch March 25, 2021 19:51
KristofferC pushed a commit that referenced this pull request Mar 26, 2021
We copy-pasted the wrong macro here, should have used `CNAMEADDR()` not `CNAME()`.  This causes segfaults on armv7l processors by trying to read from an incorrect address when loading the trampoline target address value.

(cherry picked from commit 1897e08)
@KristofferC KristofferC mentioned this pull request Mar 26, 2021
33 tasks
KristofferC pushed a commit that referenced this pull request Mar 26, 2021
We copy-pasted the wrong macro here, should have used `CNAMEADDR()` not `CNAME()`.  This causes segfaults on armv7l processors by trying to read from an incorrect address when loading the trampoline target address value.

(cherry picked from commit 1897e08)
KristofferC pushed a commit that referenced this pull request Apr 4, 2021
We copy-pasted the wrong macro here, should have used `CNAMEADDR()` not `CNAME()`.  This causes segfaults on armv7l processors by trying to read from an incorrect address when loading the trampoline target address value.

(cherry picked from commit 1897e08)
KristofferC pushed a commit that referenced this pull request Apr 4, 2021
We copy-pasted the wrong macro here, should have used `CNAMEADDR()` not `CNAME()`.  This causes segfaults on armv7l processors by trying to read from an incorrect address when loading the trampoline target address value.

(cherry picked from commit 1897e08)
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label May 4, 2021
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
We copy-pasted the wrong macro here, should have used `CNAMEADDR()` not `CNAME()`.  This causes segfaults on armv7l processors by trying to read from an incorrect address when loading the trampoline target address value.
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
We copy-pasted the wrong macro here, should have used `CNAMEADDR()` not `CNAME()`.  This causes segfaults on armv7l processors by trying to read from an incorrect address when loading the trampoline target address value.
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
We copy-pasted the wrong macro here, should have used `CNAMEADDR()` not `CNAME()`.  This causes segfaults on armv7l processors by trying to read from an incorrect address when loading the trampoline target address value.
staticfloat added a commit that referenced this pull request Dec 23, 2022
We copy-pasted the wrong macro here, should have used `CNAMEADDR()` not `CNAME()`.  This causes segfaults on armv7l processors by trying to read from an incorrect address when loading the trampoline target address value.

(cherry picked from commit 1897e08)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system:arm ARMv7 and AArch64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't build Julia v1.6.0-beta1 for Arm32bit
2 participants