Skip to content

Commit

Permalink
Fix armv7l trampoline (JuliaLang#40176)
Browse files Browse the repository at this point in the history
We copy-pasted the wrong macro here, should have used `CNAMEADDR()` not `CNAME()`.  This causes segfaults on armv7l processors by trying to read from an incorrect address when loading the trampoline target address value.
  • Loading branch information
staticfloat authored and johanmon committed Jul 5, 2021
1 parent c7681fc commit 3044444
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cli/trampolines/trampolines_arm.S
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
.global CNAME(name); \
.cfi_startproc; \
CNAME(name)##:; \
ldr ip, CONCAT(.L,CNAME(name)); \
ldr ip, CONCAT(.L,CNAMEADDR(name)); \
CONCAT(.L,CNAME(name)): ;\
add ip, pc, ip; \
ldr pc, [ip]; \
Expand Down

0 comments on commit 3044444

Please sign in to comment.