Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abspath bug for relative directories #38491

Closed
musm opened this issue Nov 19, 2020 · 0 comments · Fixed by #38981
Closed

abspath bug for relative directories #38491

musm opened this issue Nov 19, 2020 · 0 comments · Fixed by #38981
Labels
system:windows Affects only Windows

Comments

@musm
Copy link
Contributor

musm commented Nov 19, 2020

A bit of an edge case, but noticed this when looking at #23646

Assume the current directory is C:\Users\Mus\x

julia> abspath("C:x")
"C:\\Users\\Mus\\x"  # correct


julia> abspath("X:x")
"X:x"  # should be "X:\x"
@musm musm added the system:windows Affects only Windows label Nov 19, 2020
belamenso added a commit to belamenso/julia that referenced this issue Dec 23, 2020
@belamenso
Fix JuliaLang#38491: fix an abspath() edge case on Windows
1d5c34f
@belamenso belamenso mentioned this issue Dec 23, 2020
Merged
@KristofferC KristofferC mentioned this issue Dec 27, 2020
Merged
26 tasks
@KristofferC KristofferC mentioned this issue Jan 19, 2021
Merged
60 tasks
@KristofferC KristofferC mentioned this issue Feb 1, 2021
Merged
10 tasks
@KristofferC KristofferC mentioned this issue Feb 11, 2021
Merged
52 tasks
@KristofferC KristofferC mentioned this issue Mar 14, 2021
Merged
14 tasks
@KristofferC KristofferC mentioned this issue Mar 23, 2021
Merged
10 tasks
musm added a commit that referenced this issue Mar 25, 2021
@belamenso @musm @vtjnash
Fix #38491: fix an abspath() edge case on Windows (#38981)
f023677 
* Fix #38491: fix an abspath() edge case on Windows

* Update base/path.jl

Co-authored-by: Jameson Nash <vtjnash@gmail.com>

* Update base/path.jl

* Update test/path.jl

Co-authored-by: Jameson Nash <vtjnash@gmail.com>

Co-authored-by: Mustafa M <mus-m@outlook.com>
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
KristofferC pushed a commit that referenced this issue Mar 26, 2021
@belamenso @KristofferC
Fix #38491: fix an abspath() edge case on Windows (#38981)
94bf33e 
* Fix #38491: fix an abspath() edge case on Windows

* Update base/path.jl

Co-authored-by: Jameson Nash <vtjnash@gmail.com>

* Update base/path.jl

* Update test/path.jl

Co-authored-by: Jameson Nash <vtjnash@gmail.com>

Co-authored-by: Mustafa M <mus-m@outlook.com>
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
(cherry picked from commit f023677)
@KristofferC KristofferC mentioned this issue Mar 26, 2021
Merged
33 tasks
KristofferC pushed a commit that referenced this issue Apr 4, 2021
@belamenso @KristofferC
Fix #38491: fix an abspath() edge case on Windows (#38981)
f6787a9 
* Fix #38491: fix an abspath() edge case on Windows

* Update base/path.jl

Co-authored-by: Jameson Nash <vtjnash@gmail.com>

* Update base/path.jl

* Update test/path.jl

Co-authored-by: Jameson Nash <vtjnash@gmail.com>

Co-authored-by: Mustafa M <mus-m@outlook.com>
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
(cherry picked from commit f023677)
KristofferC pushed a commit that referenced this issue Apr 4, 2021
@belamenso @KristofferC
Fix #38491: fix an abspath() edge case on Windows (#38981)
63ab04c 
* Fix #38491: fix an abspath() edge case on Windows

* Update base/path.jl

Co-authored-by: Jameson Nash <vtjnash@gmail.com>

* Update base/path.jl

* Update test/path.jl

Co-authored-by: Jameson Nash <vtjnash@gmail.com>

Co-authored-by: Mustafa M <mus-m@outlook.com>
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
(cherry picked from commit f023677)
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this issue May 4, 2021
@belamenso @musm
@vtjnash @ElOceanografo
Fix JuliaLang#38491: fix an abspath() edge case on Windows (JuliaLang…
3f425db 
…#38981)

* Fix JuliaLang#38491: fix an abspath() edge case on Windows

* Update base/path.jl

Co-authored-by: Jameson Nash <vtjnash@gmail.com>

* Update base/path.jl

* Update test/path.jl

Co-authored-by: Jameson Nash <vtjnash@gmail.com>

Co-authored-by: Mustafa M <mus-m@outlook.com>
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this issue May 9, 2021
@belamenso @musm
@vtjnash @antoine-levitt
Fix JuliaLang#38491: fix an abspath() edge case on Windows (JuliaLang…
741e703 
…#38981)

* Fix JuliaLang#38491: fix an abspath() edge case on Windows

* Update base/path.jl

Co-authored-by: Jameson Nash <vtjnash@gmail.com>

* Update base/path.jl

* Update test/path.jl

Co-authored-by: Jameson Nash <vtjnash@gmail.com>

Co-authored-by: Mustafa M <mus-m@outlook.com>
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
johanmon pushed a commit to johanmon/julia that referenced this issue Jul 5, 2021
@belamenso @musm
@vtjnash @johanmon
Fix JuliaLang#38491: fix an abspath() edge case on Windows (JuliaLang…
5a6892e 
…#38981)

* Fix JuliaLang#38491: fix an abspath() edge case on Windows

* Update base/path.jl

Co-authored-by: Jameson Nash <vtjnash@gmail.com>

* Update base/path.jl

* Update test/path.jl

Co-authored-by: Jameson Nash <vtjnash@gmail.com>

Co-authored-by: Mustafa M <mus-m@outlook.com>
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
staticfloat pushed a commit that referenced this issue Dec 23, 2022
@belamenso @staticfloat
Fix #38491: fix an abspath() edge case on Windows (#38981)
fc2a7b4 
* Fix #38491: fix an abspath() edge case on Windows

* Update base/path.jl

Co-authored-by: Jameson Nash <vtjnash@gmail.com>

* Update base/path.jl

* Update test/path.jl

Co-authored-by: Jameson Nash <vtjnash@gmail.com>

Co-authored-by: Mustafa M <mus-m@outlook.com>
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
(cherry picked from commit f023677)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
system:windows Affects only Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #38491: fix an abspath() edge case on Windows belamenso/julia
1 participant
@musm