Backports release 1.6-RC3 #40029
Merged
Backports release 1.6-RC3 #40029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases (particularly after removing a phi node), we might end up in a circumstance where it appears statically that we would use a slot for both a ref and bits. Avoid generating malformed IR in this case. In the future, this situation could also possibly happen if we walked through phi nodes and attempted to merge the contents (with great care). (cherry picked from commit 9e783bb)
(cherry picked from commit bf0364b)
Fixes backtrace printing to display the number of times a frame is repeated, if there is a frame that's duplicated several times. ```julia julia> function foo() foo() end foo (generic function with 1 method) julia> foo() ERROR: StackOverflowError: Stacktrace: [1] foo() (repeats 79984 times) @ Main ./REPL[16]:1 ``` Fixes #37587. Co-authored-by: Nathan Daly <nhdaly@gmail.com> (cherry picked from commit 3276c11)
(cherry picked from commit accce7f)
Without this, a failure to find a usable `p7zip` will cause an error at startup. With this, we will at least attempt to invoke `p7zip` and fail at runtime, instead of failing at init time.
|
I played around a bit with this on Windows and it seems to work well, so let's get an RC out that works properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one should go out quickly because RC2 is kinda broken on Windows.
Backported PRs:
letwhen a global var is both shadowed and used in an RHS #39570 - fix bug inletwhen a global var is both shadowed and used in an RHSp7zipnot being found #40045 - Allow startup despitep7zipnot being foundNeed manual backport:
Non-merged PRs with backport label:
Workerstruct thread-safe. #38405 - Make Distributed.jlWorkerstruct thread-safe.