fix #39895, crash from deserialized closure using the shared method table #39916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
bugfix
JeffBezanson
changed the title
JeffBezanson
force-pushed
the
jb/fix39895
branch
from
bfb0ea6 to
f32269d
Compare
JeffBezanson
force-pushed
the
jb/fix39895
branch
from
f32269d to
d32f44b
Compare
KristofferC
pushed a commit
that referenced
this pull request
Mar 14, 2021
14 tasks
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this case we were serializing a type that uses the shared method table, but did not initialize its .mt field. This still does not fully work, but will now give a method error instead of a segfault, which is certainly worthwhile. To fix it completely we would need to send the type's methods as well, which is a bit trickier.