Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports release 1.6.0 #40150

Merged
merged 6 commits into from
Mar 23, 2021
Merged

Backports release 1.6.0 #40150

merged 6 commits into from
Mar 23, 2021

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented Mar 23, 2021

Backported PRs:

Non-merged PRs with backport label:

@KristofferC
Copy link
Member Author

@nanosoldier runtests(ALL, vs = ":release-1.6")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt

@KristofferC
Copy link
Member Author

@nanosoldier runtests(["BaryRational", "Circuitscape", "ConstrainedControl", "Diagonalizations", "FlashWeave", "HomotopyContinuation", "ImagePhaseCongruency", "ImageQuilting", "InformationGeometry", "Krylov", "LoopThrottle", "Manopt", "NeuralArithmetic", "NiceNumbers", "Poltergeist", "QPDAS", "Seleroute", "Survival", "Tar"], vs = ":release-1.6")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt

IanButterworth and others added 5 commits March 23, 2021 17:11
This commit reorders a couple touches in deps/pcre.mkl. Those touches are
intended to prevent patch application from triggering rebuild/reconf.
The present ordering doesn't quite succeed in that objective; patch
application triggers rebuild. On systems with compatible autotools,
the rebuild succeeds and the build is nonetheless happy. On systems
with incompatible versions of autotools, however, the build fails for
need of a reconf. The reordering in this commit prevents the rebuild.

Co-Authored-By: Rob Vermaas <rob.vermaas@gmail.com>
(cherry picked from commit 068420b)
@KristofferC
Copy link
Member Author

@nanosoldier runtests(["BaryRational", "Circuitscape", "ConstrainedControl", "Diagonalizations", "FlashWeave", "HomotopyContinuation", "ImagePhaseCongruency", "ImageQuilting", "InformationGeometry", "Krylov", "LoopThrottle", "Manopt", "NeuralArithmetic", "NiceNumbers", "Poltergeist", "QPDAS", "Seleroute", "Survival", "Tar"], vs = ":release-1.6")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt

@ararslan
Copy link
Member

ararslan commented Mar 23, 2021

It would be nice to have #40161, since it fixes a regression introduced in 1.6.0-rc3 (my bad I misread) a longstanding issue.

@KristofferC
Copy link
Member Author

KristofferC commented Mar 23, 2021

That's not even merged and I don't think we should put a PR straight into 1.6.0 so close to the end of the release process. At least not something that has to do with credential handling. Imo, we can try get a slightly quicker 1.6.1 out and then that has time to get tested a bit on master. Just my opinion.

@ararslan
Copy link
Member

Sure, makes sense.

@KristofferC KristofferC merged commit 6cd974f into release-1.6 Mar 23, 2021
@KristofferC KristofferC deleted the backports-release-1.6 branch March 23, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants