Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sunif() in Rmath #677

Closed
ViralBShah opened this issue Apr 7, 2012 · 6 comments
Closed

sunif() in Rmath #677

ViralBShah opened this issue Apr 7, 2012 · 6 comments
Labels
priority This should be addressed urgently
Milestone

Comments

@ViralBShah
Copy link
Member

sunif.c in the external Rmath library should use the RNG from librandom, rather than its own.

@ViralBShah
Copy link
Member Author

Depends on #353

@JeffBezanson
Copy link
Member

Why is this so important? Can we port a couple important functions, then leave the rest to extras? I'm not convinced we want Rmath in the standard library.

@ViralBShah
Copy link
Member Author

These are kind of like fdlibm, from what I can tell. Is base the std library? It seems a bit odd to define a std library going by what ships with matlab. I dont care where we put it, so long as there is a way to put it outside of extras.

-viral

On 11-Apr-2012, at 4:23 AM, JeffBezansonreply@reply.github.com wrote:

Why is this so important? Can we port a couple important functions, then leave the rest to extras? I'm not convinced we want Rmath in the standard library.


Reply to this email directly or view it on GitHub:
#677 (comment)

@JeffBezanson
Copy link
Member

I'm not thinking about matlab at all here. I'm just wondering what functions we need/want from Rmath, how many of them are there, and whether we really need to include the whole thing, just in the interest of keeping base as small as possible and reducing the number of things that need to build successfully to be able to use julia.

@ViralBShah
Copy link
Member Author

It has about the same number of functions from what I can tell, and we do need them all in the julia core distribution. Rmath.jl is more or less complete from what I can tell.

I agree that they are not relevant to be in base, and many of the current things in base can be moved out as well. My ideal situation would be to have any external library dependency not be in base. If there is an external dependency that is needed in base (pcre, double-conversion, etc.), it would be nice to check those into external. That way, people can download julia source and build it quickly.

Should we have an stdlib, that has non-base but close to production-ready code? Anything in extras should not actually ship.

-viral

On 11-Apr-2012, at 9:38 AM, JeffBezanson wrote:

I'm not thinking about matlab at all here. I'm just wondering what functions we need/want from Rmath, how many of them are there, and whether we really need to include the whole thing, just in the interest of keeping base as small as possible and reducing the number of things that need to build successfully to be able to use julia.


Reply to this email directly or view it on GitHub:
#677 (comment)

@ViralBShah
Copy link
Member Author

Implemented in #773

LilithHafner pushed a commit to LilithHafner/julia that referenced this issue Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority This should be addressed urgently
Projects
None yet
Development

No branches or pull requests

2 participants