-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: dynamic linkage of libraries and their inter-dependencies #773
Conversation
Would appreciate if anyone has a better way to do in the Makefile what I am doing with external/install-name-$(OS).sh scripts. They basically are just fixing paths for shared libraries using the install_name_tool command on Darwin. |
Sorry Viral, mucked about w/ the arpack dependencies and broke stuff. Hopefully fixed now. |
No worries - it was easy enough. I just figured out a way to work around the build issues in arpack 3.1.0, which is why I was updating it. I am done for now - so feel free to muck as necessary. :-) -viral On 29-Apr-2012, at 11:13 PM, Mike Nolta wrote:
|
(oops, butterfingers) How is it broken? |
I've accidentally closed pull requests many times — the GitHub button placesment is lousy. Ah, weird. I tried doing "make testall" again and now it works :-/ |
This patch renames |
Go for it. |
I am merging master into local_blas now (all the libuv stuff). Also, the symlinks for lib and include in $JULIAHOME are not achieving anything. I suggest that instead of installing all libraries to $JULIAHOME/deps/root/, we install them in $JULIAHOME/root, outside of deps. Julia binaries, sys.ji, etc. should also be installed inside $JULIAHOME/root, with symlinks in $JULIAHOME. This will make it much easier to create a packages for distribution. I am going to take a crack at this, and after that we can merge this back into master, so that people have to rebuild only once. |
The symlinks right now are runtime related as that is where Julia is looking for the libraries. I agree though that we should change that. |
Crap, I did it this time. How do I reopen this? |
Crap, I seem to have merged into master. |
Just making sure, did all the local_blas stuff actually make it into master, as it says "ViralBShah merged 2 commits into master from local_blas about 8 hours ago" a and I think there were more than 2 commits (I don't even know why github let you merge it as it shouldn't have allowed that until the merge conflicts were fixed) |
Yeah, I'm not sure exactly how that all happened — I had just gotten home, saw Viral's "Oh crap..." comments, realized we were in the middle of serious breakage and started trying to fix stuff. Is it possible there were actually no merge conflicts? Or maybe Viral did a manual merge and just got the direction wrong? That kind of thing is a bit unintuitive in git. |
But, yes, if you look at the commit history and state of current affairs, it certainly does look like we got everything. |
Yes, I do believe it got everything, since I merged local_blas into master instead of the other way around. Everything also builds and links as intended. -viral On 30-Apr-2012, at 9:32 PM, Stefan Karpinski wrote:
|
I have made a number of build related modifications, that will make it easier to integrate into various packaging systems and such: