Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.5] revert #17389 for 0.5.0-rc1 #17804

Merged
merged 4 commits into from
Aug 4, 2016
Merged

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Aug 4, 2016

caused a big performance regression, should have ran nanosoldier before merging

@tkelman
Copy link
Contributor Author

tkelman commented Aug 4, 2016

@nanosoldier runbenchmarks(ALL, vs = "@0030eec2f332f353e6890ca289ac2aca55532dde")

tkelman added 2 commits August 3, 2016 22:40
…ose"

This reverts commit 08ae28a, reversing
changes made to 1eeb773.

This is causing spawn test failures on Windows.
@pabloferz
Copy link
Contributor

I think I found a solution for the rest of the problems, but this is a good idea anyway.

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels

@tkelman
Copy link
Contributor Author

tkelman commented Aug 4, 2016

So since rc0, ["tuple","index",("sumelt","NTuple",30,Float64)] got almost 2x worse, a bunch of others got maybe 2x better, and a handful got 15-20% worse (but may be noise).

@tkelman tkelman merged commit b3e4722 into release-0.5 Aug 4, 2016
@tkelman tkelman deleted the tk/revert-promoteop branch August 4, 2016 08:44
@KristofferC
Copy link
Member

The native code for sumelt with tuple is identical in rc0 and master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants