use explorer rather than cmd start in Windows edit command

[stevengj]

As discussed in #20364

[tkelman]

It looks like setting JULIA_EDITOR to start was something the old batch files used to do, so not something we need to worry about any more.

[stevengj]

Can we get rid of the start check on MacOS too?

[stevengj]

Good to merge?

[tkelman]

did anyone test this locally?

[stevengj]

Is there a way to download the AppVeyor build? I can run on Windows, but I can't build Julia on Windows.

[tkelman]

appveyor doesn't upload artifacts. you can try running the same script that appveyor does. or if this were a branch in JuliaLang we could trigger the buildbot on it

[tkelman]

since this only touches julia code, build_sysimg should be enough. even eval into base should work in the post-265 world, though might want to add some debugging prints while testing to be sure the new version is what's used

[stevengj]

Can I move the branch to JuliaLang without opening a new PR?

[tkelman]

sure, doesn't need to have an open pr, just a sha that can be fetched from the JuliaLang repo

[vtjnash]

I tested that using explorer will indeed launch programs as desired. Although it also always exits with an error code (1), so ymmv. (also, unlike all of the other options, it may execute the item instead of edit it)

[stevengj]

@vtjnash, would you prefer the ShellExecute method (#20478) instead, then? It provides more informative error output (succeeding if the file was opened), and distinguishes between opening and executing the file. It also avoids passing the pathname as a command-line argument entirely.

[stevengj]

Closing in favor of #20571, then.