use ShellExecuteW rather than cmd for edit function on Windows #20571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tkelman, how do I get a Windows binary for this branch from the buildbot? |
|
win32 or win64? check https://julianightlies.s3.amazonaws.com for 2920464 once https://build.julialang.org/builders/package_win6.2-x86/builds/1277 or https://build.julialang.org/builders/package_win6.2-x64/builds/1339 are done |
|
Okay, I tried out |
tkelman
reviewed
Feb 11, 2017
| @@ -51,10 +51,7 @@ function edit(path::AbstractString, line::Integer=0) | |||
| cmd = line != 0 ? `$command $path:$line` : `$command $path` | |||
| elseif startswith(name, "notepad++") | |||
| cmd = line != 0 ? `$command $path -n$line` : `$command $path` | |||
| elseif is_windows() && (name == "start" || name == "open") | |||
| cmd = `cmd /c start /b $path` | |||
| line_unsupported = true | |||
There was a problem hiding this comment.
I don't see why this is redundant? shouldn't you still get the line number warning?
There was a problem hiding this comment.
line_unsupported = true is set in the else clause, so you still get the line-number warning.
|
Will merge in a day or two if there are no objections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20364. Updated version of #20478, and on JuliaLang so that buildbot can be used. Supersedes #20479.