Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP/RFC: add locale folder for helpdb.jl #2499

Closed
wants to merge 13 commits into from
Closed

WIP/RFC: add locale folder for helpdb.jl #2499

wants to merge 13 commits into from

Conversation

wlbksy
Copy link
Contributor

@wlbksy wlbksy commented Mar 7, 2013

If sys.ji in #2498 can be alted,
this pull would create a help folder in $(BUILD)/share/julia/help/
and LOCALE for base/util.jl to eval specific helpdb_what_ever_lang.jl

# "tr" # Turkish U
# "uk_UA" # Ukrainian U
# "zh_CN" # Simplified Chinese A
# "zh_TW" # Traditional Chinese U
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline, please.

@pao
Copy link
Member

pao commented Mar 7, 2013

One issue that's immediately clear is that the Travis builders can't produce helpdb.jl.

@wlbksy
Copy link
Contributor Author

wlbksy commented Mar 7, 2013

haven't figured it out . Please do not merge,

@pao
Copy link
Member

pao commented Mar 7, 2013

You'll need to modify the .travis.yml file I think.

We'll also need to rework the patchset in any case, so don't worry about it. I'm going to retitle to note the status.

@ViralBShah
Copy link
Member

Does this mean that we can have all the translations in one place?

@wlbksy
Copy link
Contributor Author

wlbksy commented Mar 7, 2013

I'm trying to put them in one folder. But someone gonna make sure that helpdb.jl would not be hard coded in sys.ji

@wlbksy
Copy link
Contributor Author

wlbksy commented Mar 7, 2013

Providing helpdb.jl would not be hard coded in sys.ji in the future,
i18n would be done as follows, take Simplified Chinese for example :

  1. Put your specific helpdb file helpdb_zh_CN.jl into $JULIA_HOME/../share/julia/help/
  2. Modify the last uncomment string at the end of $JULIA_HOME/../share/julia/help/LOCALE into "zh_CN"
  3. Restart REPL, test help()

@ViralBShah
Copy link
Member

We probably want those commits squashed before this can go in.

@JeffBezanson
Copy link
Member

It's very easy to change the way helpdb is loaded, and we will certainly do it to get i18n.

@JeffBezanson
Copy link
Member

Would it make sense for this to use the locale environment variables?

@wlbksy
Copy link
Contributor Author

wlbksy commented Mar 8, 2013

I myself find locale environment variable hard to use, I think that part is beyond my knowledge at present.

Besides, I believe there would be some people like to change helpdb's language freely. Inevitably, all translations would be slightly different from original version. There would be in some cases, people would like to see to English version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants