-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make helpdb.jl
and docs as part of build
#2501
Comments
I managed to generate the Chinese version. Personally speaking, I think it's better not to do what you have said. Tell people if they want to modify manual's content, just modify any As for i18n , each language's maintainer can maintain their own |
I guess it doesn't matter if |
People who don't know how to generate |
I've added this to the 1.0 milestones, since i agree we should do this, but not now. |
That's fine. |
@pao can we close this? |
Not until https://github.com/JuliaLang/julia/blob/master/doc/helpdb.jl is an invalid link. |
@staticfloat @tkelman What do you guys feel about doing this, and autogenerating helpdb.jl - requiring sphinx as a build dependency. I think we are ready for it. |
Of course, non-existence of sphinx should be detected and become a warning, rather than fail the build. |
Worth trying a PR for it, sure. Especially now that we've got the virtualenv stuff hooked up. It's making our build more reliant on Python's package manager working properly, but we can try it out. I haven't timed |
|
It's about 50 seconds using Cygwin's python, not too bad. I think AppVeyor probably has a win32 python on the path. I'd probably want to disable it on all the CI except Travis, maybe even do helpdb.jl (along with code style / whitespace checks) in a separate build matrix entry. |
That seems quite reasonable. |
Since we have the |
With #11906 I think this can be closed. AIUI |
Now that binary builds are a reality, it might be time for us to stop checking in
helpdb.jl
and make Sphinx a build dependency. We could consider making it an option so you could choose not to build the docs (another Make variable?)This has implications for the work @wlbksy is doing in #2499.
The text was updated successfully, but these errors were encountered: