RFC: Move trailing-whitespace check to a Makefile target #9553
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also build docs in the same new matrix job, ref #8917 and #2501
Currently this won't run
make check-whitespace
automatically, but we could add that as well. I'd prefer if we did that, to have it run after the tests are done, at least on Travis. That way the separate matrix job can tell you if there's a style problem (also whether or not the docs build- currently they don't build in pedantic mode, I could switch that off,alsodoctest
won't work without having also built Julia), but you still get the tests running to completion which is valuable information to get even when there are whitespace nits.Here's an example failing build when there's trailing whitespace, from rebased-away history on this branch: https://travis-ci.org/JuliaLang/julia/builds/45661147