Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Move trailing-whitespace check to a Makefile target #9553

Closed
wants to merge 2 commits into from

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Jan 2, 2015

Also build docs in the same new matrix job, ref #8917 and #2501

Currently this won't run make check-whitespace automatically, but we could add that as well. I'd prefer if we did that, to have it run after the tests are done, at least on Travis. That way the separate matrix job can tell you if there's a style problem (also whether or not the docs build - currently they don't build in pedantic mode, I could switch that off, also doctest won't work without having also built Julia), but you still get the tests running to completion which is valuable information to get even when there are whitespace nits.

Here's an example failing build when there's trailing whitespace, from rebased-away history on this branch: https://travis-ci.org/JuliaLang/julia/builds/45661147

@tkelman
Copy link
Contributor Author

tkelman commented Jan 2, 2015

Another option I was thinking of would be using a separate CI service (one of Travis' competitors) for these little checks, just to make it show up as a separate status item on PR's instead of a larger Travis matrix. I've looked into several, I think the most effective here would be either CircleCI or Shippable. Both would require checking in a new top-level .yml file, and CircleCI requires adding an SSH key to the repository for some deployment stuff that we wouldn't really need.

@tkelman tkelman force-pushed the tk/movewscheck branch 2 times, most recently from 6c1ad67 to 47e2113 Compare January 2, 2015 09:01
also build docs in the same matrix job, ref #8917 and #2501

remove comments from .travis.yml [av skip]

Change multiline commands in Travis to use &&

don't build with sphinx in pedantic mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant