Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add NEWS for mutable struct singletons change (#25854) #25862

Merged
merged 1 commit into from
Feb 2, 2018

Conversation

JeffBezanson
Copy link
Member

[ci skip]

NEWS.md Outdated
@@ -60,6 +60,10 @@ Language changes
* The syntax `1.+2` is deprecated, since it is ambiguous: it could mean either
`1 .+ 2` (the current meaning) or `1. + 2` ([#19089]).

* Mutable structs with no fields are no longer singletons; it is now possible to make
multuple instances of them that can be distinguished by `===` ([#25854]).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multuple

Tuples on the brain?

also a small doc clarification

[ci skip]
Copy link
Member

@Keno Keno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ararslan ararslan merged commit 18c14e6 into master Feb 2, 2018
@ararslan ararslan deleted the jb/emptymutablenews branch February 2, 2018 20:29
WenjieZ added a commit to WenjieZ/julia that referenced this pull request Jan 17, 2020
Remove the paragraphs saying "Immutable composite types with no fields are singletons".

Previously, `MutableNoFields() === MutableNoFields()`, but this was changed in JuliaLang#25854. When that got changed, the existing docs was tweaked to say that the struct had to be immutable(JuliaLang#25862) . However, there is no longer anything specific about it having no fields. The docs about singletons can thus just be removed since they are not special anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants