Fix #34414: remove legacy doc content [skip ci] #34416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the paragraphs saying "Immutable composite types with no fields are singletons". Previously, `MutableNoFields() === MutableNoFields()`, but this was changed in JuliaLang#25854. When that got changed, the existing docs was tweaked to say that the struct had to be immutable(JuliaLang#25862) . However, there is no longer anything specific about it having no fields. The docs about singletons can thus just be removed since they are not special anymore.
yuyichao
requested changes
Jan 17, 2020
|
Please reopen if @yuyichao's suggestion is updated into this PR. |
|
Sorry for my delayed reply. I am working on COVID-19, and thus this PR is not on my priority list. I would be happy if someone else is willing to take care of this issue. |
|
@JeffBezanson Perhaps this is a quick one for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the paragraphs saying "Immutable composite types with no fields are singletons".
Previously,
MutableNoFields() === MutableNoFields(), but this was changed in #25854. When that got changed, the existing docs was tweaked to say that the struct had to be immutable(#25862) . However, there is no longer anything specific about it having no fields. The docs about singletons can thus just be removed since they are not special anymore.