Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.6] some compiler performance improvements #26897

Merged
merged 1 commit into from
Apr 28, 2018

Conversation

JeffBezanson
Copy link
Member

Mostly due to avoiding specialization of closures in comprehensions in the compiler itself. Most of these changes are already on master, or not worth applying due to code being in flux.

Sysimg build time and size on release-0.6:

real	3m4.122s
user	3m1.152s
-rw-rw-r-- 1 jeff jeff  2291415 Apr 24 18:56 inference.ji
-rwxrwxr-x 1 jeff jeff 39370374 Apr 24 18:59 sys.so

and on this branch:

real	2m59.307s
user	2m56.835s
-rw-rw-r-- 1 jeff jeff  2237103 Apr 24 18:52 inference.ji
-rwxrwxr-x 1 jeff jeff 38218607 Apr 24 18:55 sys.so

I think I've seen more improvement in some package precompile times, but it's hard to tell since there is a lot of variability (probably #25900).

mostly due to avoiding specialization of closures in comprehensions in the compiler itself
@ararslan
Copy link
Member

Thanks Jeff! Looks like macOS is having some kind of issue with LLVM and 64-bit Windows is hitting EPERM from unlink. Both surely unrelated, both odd.

@ararslan ararslan mentioned this pull request Apr 27, 2018
7 tasks
@ararslan ararslan closed this Apr 27, 2018
@ararslan ararslan reopened this Apr 27, 2018
@ararslan
Copy link
Member

ararslan commented Apr 27, 2018

The macOS build is looking better now, but 64-bit Windows is still getting EPERM, which is odd because I'm not getting it on #26915. EDIT: Maybe that branch actually fixes the issue.

@ararslan
Copy link
Member

Jeff, can you try changing the base branch of the pull request to aa/backports-0.6.3 to see if that fixes the Windows EPERM issue?

@vchuravy vchuravy changed the base branch from release-0.6 to aa/backports-0.6.3 April 27, 2018 23:30
@vchuravy vchuravy closed this Apr 27, 2018
@vchuravy vchuravy reopened this Apr 27, 2018
@ararslan
Copy link
Member

Looks like CI didn't restart on the last open/close? Anyway, I'm just going to merge this into my branch and if it introduces failures I'll revert.

@ararslan ararslan merged commit 0b39e5f into aa/backports-0.6.3 Apr 28, 2018
@ararslan ararslan deleted the jb/06_compiler_perf branch April 28, 2018 00:34
ararslan pushed a commit that referenced this pull request May 8, 2018
mostly due to avoiding specialization of closures in comprehensions in the compiler itself
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants