DO NOT MERGE! NFC for testing 0.6 Windows EPERM on AV #27271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seriously, do not merge this. [bsd skip]
|
Okay folks, the good news is that the release branch in its current state is not broken on Windows. I'll try reverting @JeffBezanson's seemingly innocuous commit from #26897 to see if it fixes things on my backports branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for using AppVeyor for this, but I don't have access to Windows locally and building from scratch on AppVeyor from my fork would time out the build since there's no cache. FreeBSD CI has been skipped and I'll cancel Travis and Circle manually to avoid adding to those queues unnecessarily.
Basically, the deal is that we keep getting a permissions error (
EPERM) fromunlinkwhen running the distributed tests on 64-bit Windows. This has been happening on my backports branch for 0.6.3, but the error was first seen on #26897, which initially targetedrelease-0.6rather thanaa/backports-0.6.3. That PR didn't touch anything filesystem-related, which suggests that the issue may already exist on the release branch. Thus I'm opening this PR against the release branch to test that theory.The change here is non-functional, but seriously, do not merge this.