Fix deadlock caused by REPL blinking #30112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The REPL beeping (blinking) code made the assumption that the prompt prefix is always a String. That's not necessarily the case, and in fact it can be an arbitrary funcion to be called when the prompt is printed (e.g. TerminalExtensions uses this for the iTerm integration). However, even worse, this code acquired a lock that it never released on error, causing a deadlock. Fix the original assumption and also add a try/catch/finally block such that future errors print the error rather than deadlocking the terminal. Fixes Keno/TerminalExtensions.jl#40
vtjnash
approved these changes
Nov 21, 2018
KristofferC
added
bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The REPL beeping (blinking) code made the assumption that the prompt
prefix is always a String. That's not necessarily the case, and in
fact it can be an arbitrary funcion to be called when the prompt is
printed (e.g. TerminalExtensions uses this for the iTerm integration).
However, even worse, this code acquired a lock that it never released
on error, causing a deadlock. Fix the original assumption and also
add a try/catch/finally block such that future errors print the error
rather than deadlocking the terminal.
Fixes Keno/TerminalExtensions.jl#40