Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #30006, getindex accessing fields that might not exist #30405

Merged
merged 2 commits into from
Dec 17, 2018
Merged

Fix #30006, getindex accessing fields that might not exist #30405

merged 2 commits into from
Dec 17, 2018

Conversation

raghav9-97
Copy link
Contributor

Fixes #30006

@raghav9-97
Copy link
Contributor Author

I don't think this build fail is because of my code.

@fredrikekre fredrikekre added the needs tests Unit tests are required for this change label Dec 16, 2018
@ViralBShah
Copy link
Member

Yes, failure is not relevant. Should be good to merge with some tests.

@ViralBShah
Copy link
Member

This should serve as a test from #30006:

@test Base.Slice(Base.OneTo(3))[Int32(1)] == Int32(1)

@JeffBezanson
Copy link
Member

This could also use a better commit message, e.g. fix #30006, range getindex accessing fields that might not exist.

@ViralBShah ViralBShah added the sparse Sparse arrays label Dec 17, 2018
@ViralBShah
Copy link
Member

Adding sparse label since it fixes a known issue in sparse.

@raghav9-97
Copy link
Contributor Author

I have added required tests, please review this PR.

@fredrikekre fredrikekre removed the needs tests Unit tests are required for this change label Dec 17, 2018
@ViralBShah
Copy link
Member

This looks good. Can be merged once CI is complete. Whoever merges it can improve the commit message.

@raghav9-97 raghav9-97 changed the title Modified getindex(::AbstractRange) Fix #30006, getindex accessing fields that might not exist Dec 17, 2018
@raghav9-97
Copy link
Contributor Author

Does this message looks good enough?

@ViralBShah
Copy link
Member

The comment was about the message in the commit itself (which you have to fix with git rebase -i). But like I said, don't worry about it, since I can fix while squash merging.

@raghav9-97
Copy link
Contributor Author

Ok, I misunderstood the comment, Thanks for helping out @ViralBShah

@raghav9-97
Copy link
Contributor Author

raghav9-97 commented Dec 17, 2018 •
edited
Loading

@ViralBShah Is this PR now ready to be merged?

@ViralBShah ViralBShah merged commit 64133f6 into JuliaLang:master Dec 17, 2018
@ViralBShah
Copy link
Member

@raghav9-97 Thanks for the PR. It seems you are relatively new to Julia (at least as a committer). So welcome!

@raghav9-97
Copy link
Contributor Author

@ViralBShah Thanks for helping me out and guiding me throughout the process.

@raghav9-97 raghav9-97 deleted the nonint branch December 17, 2018 15:30
KristofferC pushed a commit that referenced this pull request Dec 20, 2018
@raghav9-97 @KristofferC
Fix #30006, getindex accessing fields that might not exist (#30405)
2348c7b 
* Fix #30006, range getindex accessing fields that might not exist
* Add tests for #30006

(cherry picked from commit 64133f6)
@KristofferC KristofferC mentioned this pull request Dec 20, 2018
Merged
52 tasks
@KristofferC KristofferC mentioned this pull request Dec 30, 2018
Closed
53 tasks
KristofferC pushed a commit that referenced this pull request Dec 30, 2018
@raghav9-97 @KristofferC
Fix #30006, getindex accessing fields that might not exist (#30405)
7352037 
* Fix #30006, range getindex accessing fields that might not exist
* Add tests for #30006

(cherry picked from commit 64133f6)
KristofferC pushed a commit that referenced this pull request Dec 31, 2018
@raghav9-97 @KristofferC
Fix #30006, getindex accessing fields that might not exist (#30405)
e4a7db2 
* Fix #30006, range getindex accessing fields that might not exist
* Add tests for #30006

(cherry picked from commit 64133f6)
@KristofferC
Copy link
Member

KristofferC commented Jan 5, 2019 •
edited
Loading

Already backported to 1.1.0.

@StefanKarpinski StefanKarpinski added backport 1.0 triage This should be discussed on a triage call and removed backport 1.0 triage This should be discussed on a triage call labels Jan 31, 2019
@JeffBezanson JeffBezanson removed triage This should be discussed on a triage call triage backport pending 1.0 labels Jan 31, 2019
@KristofferC KristofferC mentioned this pull request Feb 4, 2019
Merged
39 tasks
KristofferC pushed a commit that referenced this pull request Feb 4, 2019
@raghav9-97 @KristofferC
Fix #30006, getindex accessing fields that might not exist (#30405)
ae58ea5 
* Fix #30006, range getindex accessing fields that might not exist
* Add tests for #30006
KristofferC pushed a commit that referenced this pull request Feb 4, 2019
@raghav9-97 @KristofferC
Fix #30006, getindex accessing fields that might not exist (#30405)
51f90ae 
* Fix #30006, range getindex accessing fields that might not exist
* Add tests for #30006
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
@raghav9-97 @KristofferC
Fix #30006, getindex accessing fields that might not exist (#30405)
eb852a2 
* Fix #30006, range getindex accessing fields that might not exist
* Add tests for #30006
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
@raghav9-97 @KristofferC
Fix #30006, getindex accessing fields that might not exist (#30405)
1856c8c 
* Fix #30006, range getindex accessing fields that might not exist
* Add tests for #30006
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
@raghav9-97 @KristofferC
Fix #30006, getindex accessing fields that might not exist (#30405)
8f251a1 
* Fix #30006, range getindex accessing fields that might not exist
* Add tests for #30006
KristofferC pushed a commit that referenced this pull request Apr 19, 2019
@raghav9-97 @KristofferC
Fix #30006, getindex accessing fields that might not exist (#30405)
e37cf14 
* Fix #30006, range getindex accessing fields that might not exist
* Add tests for #30006

(cherry picked from commit 64133f6)
KristofferC pushed a commit that referenced this pull request Apr 20, 2019
@raghav9-97 @KristofferC
Fix #30006, getindex accessing fields that might not exist (#30405)
63414f7 
* Fix #30006, range getindex accessing fields that might not exist
* Add tests for #30006
KristofferC pushed a commit that referenced this pull request Apr 20, 2019
@raghav9-97 @KristofferC
Fix #30006, getindex accessing fields that might not exist (#30405)
7fb5541 
* Fix #30006, range getindex accessing fields that might not exist
* Add tests for #30006

(cherry picked from commit 64133f6)
@KristofferC KristofferC added the bugfix This change fixes an existing bug label May 16, 2019
@iryabink iryabink mentioned this pull request May 27, 2019
Closed
@dkarrasch dkarrasch mentioned this pull request Aug 1, 2019
Merged
KristofferC pushed a commit that referenced this pull request Feb 20, 2020
@raghav9-97 @KristofferC
Fix #30006, getindex accessing fields that might not exist (#30405)
ff00349 
* Fix #30006, range getindex accessing fields that might not exist
* Add tests for #30006
KristofferC pushed a commit that referenced this pull request Feb 20, 2020
@raghav9-97 @KristofferC
Fix #30006, getindex accessing fields that might not exist (#30405)
67ba3ca 
* Fix #30006, range getindex accessing fields that might not exist
* Add tests for #30006

(cherry picked from commit 64133f6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix This change fixes an existing bug sparse Sparse arrays
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sparse matrix with non-Int64 index type slice assignment failure
6 participants
@raghav9-97 @ViralBShah @JeffBezanson @KristofferC @StefanKarpinski @fredrikekre