Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #30679, call correct method for invoke calls in jl_invoke fallback #30880

Merged
merged 1 commit into from
Feb 6, 2019
Merged

fix #30679, call correct method for invoke calls in jl_invoke fallback #30880

merged 1 commit into from
Feb 6, 2019

Conversation

JeffBezanson
Copy link
Member

No description provided.

@JeffBezanson JeffBezanson added bugfix This change fixes an existing bug backport pending 1.0 labels Jan 28, 2019
@JeffBezanson JeffBezanson requested a review from vtjnash January 28, 2019 22:35
@JeffBezanson
Copy link
Member Author

fixes #30679

@Keno
Copy link
Member

Keno commented Jan 29, 2019

Can we concoct a test?

@StefanKarpinski StefanKarpinski added the triage This should be discussed on a triage call label Jan 31, 2019
@JeffBezanson JeffBezanson added backport 1.0 and removed triage This should be discussed on a triage call triage backport pending 1.0 labels Jan 31, 2019
@KristofferC KristofferC mentioned this pull request Feb 4, 2019
Merged
39 tasks
@JeffBezanson
Copy link
Member Author

Test added.

@JeffBezanson JeffBezanson merged commit f97c443 into master Feb 6, 2019
@JeffBezanson JeffBezanson deleted the jb/fix30679 branch February 6, 2019 15:16
@dwfmarchant dwfmarchant mentioned this pull request Feb 6, 2019
Closed
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
@JeffBezanson @KristofferC
fix #30679, call correct method for invoke calls in jl_invoke fal…
8f1b9d3 
…lback (#30880)

(cherry picked from commit f97c443)
@KristofferC KristofferC mentioned this pull request Feb 11, 2019
Merged
39 tasks
@KristofferC
Copy link
Member

Needs manual backport to 1.0.4 #30954

@JeffBezanson JeffBezanson mentioned this pull request Apr 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JeffBezanson @Keno @KristofferC @vtjnash @StefanKarpinski