Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports for 1.1.1 #31039

Merged
merged 40 commits into from
May 7, 2019
Merged

Backports for 1.1.1 #31039

merged 40 commits into from
May 7, 2019

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented Feb 11, 2019

Backported PRs:

Non-merged PRs with backport label:

vtjnash and others added 22 commits February 11, 2019 13:36
broken by their move to cmake causing a switch away from the standard --host/--build autoconf

fix #28046

(cherry picked from commit 041c214)
(cherry picked from commit 1daf145)
fix #29244, document `Expr`
fix #30648, link `isdefined` to `isassigned`
update docstring for `macro`
fix variable scope description in manual

(cherry picked from commit 0ecaffb)
also add some missing doc strings and improve others

(cherry picked from commit 0bb0332)
(cherry picked from commit 83a7f3b)
…30754)

fixes #22013, fixes #24871, fixes #26933, fixes #29282,
fixes #29361, fixes #30348 and fixes #30506. 

(cherry picked from commit b8c0ec8)
The example demonstrating the use of RemoteChannel does not work in Julia 0.7+,
due to new scoping of variables inside of for loops. Consequently, the example
would not work as intended. Adding global scope to the variable corrects this
problem.

(cherry picked from commit 082ec88)
On most platforms this doesn't make a difference,
but the PowerPC ABI uses the signature to decide
whether or not to allocate a parameter save area.
Without this, the caller does not, but the callee
assumes it's there causing the callee to overwrite
critical parts of the caller stack.

Fixes #27007

(cherry picked from commit 8fa0645)
- document indexing by different numbers of indices
- remove/supercede an outdated section on the same in devdocs/subarray

(cherry picked from commit 1c1fc03)
* Fallback for copying views into sparse matrices

* SparseArray --> SparseVecOrMat

* move copy method to sparsevector

* use the union explicitly

(cherry picked from commit d6bcb5a)
@KristofferC KristofferC added the DO NOT MERGE Do not merge this PR! label Feb 11, 2019
fredrikekre and others added 6 commits April 15, 2019 13:12
(cherry picked from commit 300a336)
The `enumerate` method referred to in the current definition no longer exists and has been deprecated to a method of `pairs` in 0.7.

Thanks to @simonschoelly for pointing this out.

```
julia> using OffsetArrays;
julia> pairs(IndexLinear(),OffsetArray(1:5, -2:2))
pairs(::OffsetArray{Int64,1,UnitRange{Int64}}) with 5 entries:
  -2 => 1
  -1 => 2
  0  => 3
  1  => 4
  2  => 5
```

(cherry picked from commit 549240a)
* Fix 29545: Implement unaliascopy for ReinterpretArray

(cherry picked from commit f611b46)
@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

@fredrikekre
Copy link
Member

fredrikekre commented Apr 16, 2019

  • Travis: internet connection error during Pkg tests on macOS.
  • package_freebsd64 looks to have the same gmp issue as Backports for 1.0.4 #30954 (comment)
  • package_macos64 and package_win64 has the following error:
    /usr/lib/gcc/x86_64-pc-cygwin/7.4.0/../../../../x86_64-pc-cygwin/bin/ld: final link failed: File truncated
    collect2: error: ld returned 1 exit status
    
    followed by other failures with openblas/llvm.

@KristofferC
Copy link
Member Author

@nanosoldier runbenchmarks(ALL, vs = ":release-1.1")

also submitted to gmp-bugs@gmplib.org patch list

(cherry picked from commit b446398)
@ararslan ararslan added the needs pkgeval Tests for all registered packages should be run with this change label Apr 16, 2019
@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

@KristofferC KristofferC reopened this Apr 17, 2019
@ararslan
Copy link
Member

PkgEval results: https://gist.github.com/ararslan/8ee7060a539badc996e4226ef02757f3. Regressions in CategoricalArrays (looks okay I think) and YaoBlocks.

(cherry picked from commit d5e365c)
@KristofferC
Copy link
Member Author

YaoBlocks errors on 1.1.0 for me to.

martinholters and others added 5 commits April 20, 2019 11:11
(cherry picked from commit c36e70b)
* minor fixes in multiplication with Diagonals

* correct rmul!(A,D), revert changes in AdjTrans(x)*D

* [r/l]mul!: replace conj by adjoint, add transpose

* add tests

* fix typo

* relax some tests, added more tests

* simplify tests, strict equality

(cherry picked from commit a93185f)
@KristofferC KristofferC force-pushed the backport-1.1.1 branch 3 times, most recently from adc798a to 0bc6c5d Compare April 20, 2019 21:26
@ghost
Copy link

ghost commented Apr 24, 2019

(Should we add an entry to the summary block at the top of this PR for #31699?)

Something like:

@ararslan ararslan added the release Release management and versioning. label May 4, 2019
@ararslan
Copy link
Member

ararslan commented May 4, 2019

PkgEval says we're good except for CategoricalArrays, which we've determined is fine. I think for FreeBSD CI we'll need a GMP patch?

@ararslan ararslan removed needs pkgeval Tests for all registered packages should be run with this change DO NOT MERGE Do not merge this PR! labels May 6, 2019
@ararslan
Copy link
Member

ararslan commented May 7, 2019

Elliot fixed CI, so we're all good now.

@ararslan ararslan merged commit b975b5f into release-1.1 May 7, 2019
@ararslan ararslan deleted the backport-1.1.1 branch May 7, 2019 05:46
@NHDaly NHDaly assigned NHDaly and unassigned NHDaly Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Release management and versioning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.