-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow chop to take an empty string #31312
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
approved these changes
Mar 11, 2019
Obviously needs to be fixed but I worry that this may just be bandaiding the real problem, namely that |
Have merged this as the simplest most conservative fix that can and should be backported. |
eulerkochy
added a commit
to eulerkochy/julia
that referenced
this pull request
Mar 15, 2019
KristofferC
pushed a commit
that referenced
this pull request
Apr 15, 2019
(cherry picked from commit 023c8e4)
KristofferC
pushed a commit
that referenced
this pull request
Apr 17, 2019
(cherry picked from commit 023c8e4)
nalimilan
added a commit
to JuliaData/CategoricalArrays.jl
that referenced
this pull request
Apr 19, 2019
Since JuliaLang/julia#31312, chop("") returns "" instead of throwing.
nalimilan
added a commit
to JuliaData/CategoricalArrays.jl
that referenced
this pull request
Apr 19, 2019
Since JuliaLang/julia#31312, chop("") returns "" instead of throwing.
KristofferC
pushed a commit
that referenced
this pull request
Apr 20, 2019
(cherry picked from commit 023c8e4)
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
(cherry picked from commit 023c8e4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following behavior contradicts the docstring of
chop
. So, I fixed the behavior in this pull request.