without reverting JuliaLang#31312

eulerkochy · Mar 15, 2019 · 140d53d · 140d53d
1 parent 61c2086
commit 140d53d
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/base/strings/util.jl b/base/strings/util.jl
@@ -96,7 +96,10 @@ julia> chop(a, head = 5, tail = 5)
 ```
 """
 function chop(s::AbstractString; head::Integer = 0, tail::Integer = 1)
-    SubString(s, nextind(s, firstindex(s), head), prevind(s, ncodeunits(s) + 1, tail) - 1)
+    if isempty(s)
+        return SubString(s)
+    end
+    SubString(s, nextind(s, firstindex(s), head), prevind(s, lastindex(s), tail))
 end
 
 # TODO: optimization for the default case based on