Fix -, conj, and conj! for sparse matrices with invalid entries in nzval
#31187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinholters
added
sparse
fredrikekre
reviewed
Feb 27, 2019
martinholters
force-pushed
the
mh/fix_sparse_unary
branch
from
2414ceb to
4ba892a
Compare
|
CI failure (AV 32bit) is unrelated: Network problems during Pkg test. |
|
Seems like a straightforward bugfix. I propose removing the triage label since backporting is obvious. |
This was referenced Apr 15, 2019
Merged
Merged
KristofferC
pushed a commit
that referenced
this pull request
Apr 20, 2019
KristofferC
pushed a commit
that referenced
this pull request
Apr 20, 2019
55 tasks
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. https://github.com/JuliaLang/julia/issues/30662#issuecomment-467436621. I chose to keep the extra elements in
nzval, just not apply-orconjto them, respectively. This should be minimally invasive and hence safe for backporting. In the future, we might consider instead dropping extra entries in these functions.