Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump MPFR to 4.0.2 #31041

Merged
merged 1 commit into from
Feb 13, 2019
Merged

bump MPFR to 4.0.2 #31041

merged 1 commit into from
Feb 13, 2019

Conversation

simonbyrne
Copy link
Contributor

No description provided.

@ViralBShah
Copy link
Member

A bit unrelated to this PR, but as we move to BB for all julia deps, will we still need to bump things like this?

@simonbyrne
Copy link
Contributor Author

Probably a question for @staticfloat?

@staticfloat
Copy link
Member

I don’t think we’re quite to the point of removing building from source as being the default way of getting Julia put together. The BB tarballs are more of a convenience/CI tool than the primary way to
build Julia.

@StefanKarpinski
Copy link
Member

StefanKarpinski commented Feb 12, 2019

The BB tarballs are more of a convenience/CI tool than the primary way to build Julia.

I would actually very much like to switch to using BB tarballs by default. I don't think it will be truly reliable until we have everyone doing it that way. What's the downside? I think I've built LLVM and OpenBLAS and MPFR enough times in my life at this point.

@staticfloat
Copy link
Member

I think it comes down to an internal bias I have against downloading binary blobs during the build of an opensource project. But as long as we ensure that a make FROM_SOURCE=1 or something works, we could definitely have it auto-download tarballs.

@StefanKarpinski
Copy link
Member

We should definitely keep the build everything option working but we can test that like once a day or only for changes that affect makefiles or the deps directory. But there's a lot of people who build from source but that really don't need to build all the deps from source.

@simonbyrne simonbyrne merged commit 300a336 into master Feb 13, 2019
@simonbyrne simonbyrne deleted the sb/mpfr-4.0.2 branch February 13, 2019 00:06
KristofferC pushed a commit that referenced this pull request Apr 15, 2019
(cherry picked from commit 300a336)
@KristofferC KristofferC mentioned this pull request Apr 15, 2019
39 tasks
KristofferC pushed a commit that referenced this pull request Apr 17, 2019
(cherry picked from commit 300a336)
@KristofferC KristofferC mentioned this pull request Apr 19, 2019
39 tasks
KristofferC pushed a commit that referenced this pull request Apr 20, 2019
(cherry picked from commit 300a336)
KristofferC pushed a commit that referenced this pull request Feb 20, 2020
(cherry picked from commit 300a336)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants