Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

put back broadcast behavior with repeated indices, changed by #31300 #31391

Merged
merged 1 commit into from
May 23, 2019
Merged

put back broadcast behavior with repeated indices, changed by #31300 #31391

merged 1 commit into from
May 23, 2019

Conversation

JeffBezanson
Copy link
Sponsor Member

No description provided.

@JeffBezanson JeffBezanson added the domain:broadcast Applying a function over a collection label Mar 18, 2019
@mbauman
Copy link
Sponsor Member

mbauman commented Mar 18, 2019 •
edited
Loading

So this keeps the bulk of #31300, but it just restores the special case for refs that prevent the use of a single temporary in that case. LGTM!

@JeffBezanson JeffBezanson mentioned this pull request Mar 19, 2019
Open
@ararslan ararslan mentioned this pull request Mar 20, 2019
Merged
@willtebbutt willtebbutt mentioned this pull request Mar 21, 2019
Merged
@JeffBezanson JeffBezanson added the status:triage This should be discussed on a triage call label May 18, 2019
@JeffBezanson JeffBezanson added this to the 1.2 milestone May 18, 2019
@JeffBezanson
Copy link
Sponsor Member Author

This addresses what would be a breaking change in 1.2. We might want to merge it for compatibility, then release #31407 (a proper, well-thought-out version of the breaking change 😄 ) in 1.3.

@JeffBezanson
Copy link
Sponsor Member Author

Triage says merge this for 1.1 compat.

@JeffBezanson JeffBezanson merged commit fb181c3 into master May 23, 2019
@JeffBezanson JeffBezanson deleted the jb/repeatedindexbcast branch May 23, 2019 18:33
@JeffBezanson JeffBezanson removed the status:triage This should be discussed on a triage call label May 23, 2019
KristofferC pushed a commit that referenced this pull request May 23, 2019
@JeffBezanson @KristofferC
put back broadcast behavior with repeated indices, changed by #31300 (#…
b4ff156 
…31391)

(cherry picked from commit fb181c3)
@KristofferC KristofferC mentioned this pull request May 23, 2019
Closed
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
domain:broadcast Applying a function over a collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JeffBezanson @mbauman @KristofferC