fix LibGit2 test: unknown repo now returns error instead of EAUTH #32219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
test
Merged
|
The comments in this test says the intent is to test the behavior of hitting an unknown repo, and the credentials are just there because GitHub would ask for them before responding. |
|
Needs to be backported so ci can pass on release branches. |
|
Seems back to EAUTH? https://travis-ci.org/JuliaLang/julia/jobs/542982697? Maybe just allow both errors? |
55 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test literally has my name on it so I figure this is my job :)
This may not be an ideal fix, depending on the intent of this test. If it's just checking what happens with an unknown URL, it's ok, but if we need to test incorrect credentials we need to do something else.
Fixes #32186