Allow both EAUTH and ERROR for bad URL test in LibGit2 tests. #32268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
approved these changes
Jun 8, 2019
|
Actually, I think it's the other line (or maybe both) |
|
Failures now seem to be on https://github.com/JuliaLang/julia/pull/32268/files#diff-e6061806c77edc60566965a63145f5a4R71 though. I think we always get a GitError though, so the line you refered to is fine I think? |
|
My point is that this is not the line that the referenced PR changed |
|
🤦♂️ |
fredrikekre
changed the title
|
Backporting since this happens on CI for 1.2-RC2. |
55 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #32219 (comment)