Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added ^ method for UniformScaling #34008

Merged
merged 10 commits into from
Dec 11, 2019
Merged

added ^ method for UniformScaling #34008

merged 10 commits into from
Dec 11, 2019

Conversation

MasonProtter
Copy link
Contributor

This change allows us to do

julia> (2I)^2
UniformScaling{Int64}
4*I

which is occasionally useful and caused this question.

@MasonProtter @simeonschaub
Update stdlib/LinearAlgebra/test/uniformscaling.jl
bc87e0e 
Co-Authored-By: simeonschaub <simeondavidschaub99@gmail.com>
@fredrikekre fredrikekre added the linear algebra Linear algebra label Dec 2, 2019
@StefanKarpinski
Copy link
Member

I approve in concept, should obviously pass tests though 😁

@MasonProtter
Copy link
Contributor Author

MasonProtter commented Dec 3, 2019 •
edited
Loading

Should obviously pass tests though 😁

I was super confused as to why my broadcasted method wasn't being used in the tests until I realized that I was testing it with a literal power! Added methods to deal with literal powers and made the tests check both literal and variable powers.

Tests should pass now hopefully.

@MasonProtter
Copy link
Contributor Author

Okay, tests are all passing! If I could get a quick re-review from those interested, that'd be great.

@MasonProtter
Copy link
Contributor Author

CI failure appears to be unrelated.

@MasonProtter MasonProtter mentioned this pull request Dec 9, 2019
Merged
@MasonProtter
Copy link
Contributor Author

Can this be merged?

@dkarrasch dkarrasch merged commit 1432c5a into JuliaLang:master Dec 11, 2019
@jagot jagot mentioned this pull request Nov 26, 2024
Open
17 tasks
@dkarrasch dkarrasch mentioned this pull request Feb 19, 2020
Merged
KristofferC pushed a commit that referenced this pull request Apr 11, 2020
@MasonProtter @fredrikekre @KristofferC
added ^ method for UniformScaling (#34008)
adf27cb 
Co-Authored-By: simeonschaub <simeondavidschaub99@gmail.com>

Co-Authored-By: Fredrik Ekre <ekrefredrik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkarrasch dkarrasch dkarrasch left review comments

@fredrikekre fredrikekre fredrikekre left review comments

@simeonschaub simeonschaub simeonschaub left review comments

@mschauer mschauer mschauer approved these changes

@StefanKarpinski StefanKarpinski StefanKarpinski approved these changes

Assignees
No one assigned
Labels
linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MasonProtter @StefanKarpinski @mschauer @simeonschaub @fredrikekre @dkarrasch