Fix build issues introduced in #28872 #34819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
Apologies also for not noticing that. |
|
In general, it is a good idea to close and open the PR to get a fresh CI run if the PR has been sitting for a while. |
I know, but the last commit of the rebase was passing all tests, without exception: 6cc47a7 |
birm
pushed a commit
to birm/julia
that referenced
this pull request
Feb 22, 2020
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My sincere apologies. Rebasing the old PR turned out to be more complicated than I thought, since some
^-related methods had been introduced meanwhile in #34008.