Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtests: Print currently running tests when asked #34212

Merged
merged 1 commit into from
Dec 29, 2019
Merged

Conversation

Keno
Copy link
Member

@Keno Keno commented Dec 28, 2019

With this patch, pressing '?' while the test are running will print
which tests are still running. Of course, you could just try to look
through the log to try to figure out which tests have started but not
yet finished, but that's pretty annoying to do. Being able to just ask
is much easier for the impatient developer.

Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a nice idea! Should we add start time (or time elapsed since starting) too? (i.e., by making the Set a Dict)

test/runtests.jl Outdated
Base.throwto(t, InterruptException())
break
elseif c == '?'
println("Currently running: ", join(running_tests, ", "))
break
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
break

With this patch, pressing '?' while the test are running will print
which tests are still running. Of course, you could just try to look
through the log to try to figure out which tests have started but not
yet finished, but that's pretty annoying to do. Being able to just ask
is much easier for the impatient developer.
@Keno Keno merged commit 4c67921 into master Dec 29, 2019
@Keno Keno deleted the kf/runningtests branch December 29, 2019 22:18
KristofferC pushed a commit that referenced this pull request Apr 11, 2020
With this patch, pressing '?' while the test are running will print
which tests are still running. Of course, you could just try to look
through the log to try to figure out which tests have started but not
yet finished, but that's pretty annoying to do. Being able to just ask
is much easier for the impatient developer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants