Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate an error for closure cfunctions on unsupported platforms. #34326

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Jan 9, 2020

Work around the fatal errors on ARM and PPC (#27174 and #32154) when compiling closure cfunctions, because that blocks nightlies from getting generated. The LLVM PPC back-end does seem to support trampolines though, so we could probably fix that if somebody cares.

@maleadt maleadt added system:arm ARMv7 and AArch64 compiler:codegen Generation of LLVM IR and native code system:powerpc PowerPC labels Jan 9, 2020
test/ccall.jl Outdated Show resolved Hide resolved
@vchuravy
Copy link
Member

vchuravy commented Jan 9, 2020

x-ref: #32154

Also I am fine with this, but I would like to eventually have this fixed. Do you have a reference for the PPC support?

@maleadt
Copy link
Member Author

maleadt commented Jan 10, 2020

Hmm, looked like the tests timed out: https://build.julialang.org/#/builders/28/builds/7025
Trying to reproduce locally now. Is there a way to use #34212 on the bots when stuff timeouts?

@vchuravy: Do you have a reference for the PPC support?

https://github.com/llvm/llvm-project/blob/995c18fc5051850782b1c096233867b8e56e0dea/llvm/lib/Target/PowerPC/PPCISelLowering.h#L1060-L1061

@maleadt
Copy link
Member Author

maleadt commented Jan 10, 2020

Maybe it's just very slow?

Currently running: 
SparseArrays/sparse (running for 73 minutes)
SparseArrays/sparsevector (running for 72 minutes)
LinearAlgebra/triangular (running for 67 minutes)
LinearAlgebra/qr (running for 61 minutes)

@staticfloat Can we bump the 2700 seconds to something higher for aarch64 and try again?

@staticfloat
Copy link
Member

JuliaCI/julia-buildbot@a5b45cc

I've re-started your build here: https://build.julialang.org/#/builders/28/builds/7083

@maleadt maleadt force-pushed the tb/cfunction_closure_error branch 2 times, most recently from 4f84e22 to fd7eaca Compare January 13, 2020 10:25
@maleadt
Copy link
Member Author

maleadt commented Jan 13, 2020

Looks like #34155 broke something. Rebased right before that, currently running at https://build.julialang.org/#/builders/28/builds/7103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:codegen Generation of LLVM IR and native code system:arm ARMv7 and AArch64 system:powerpc PowerPC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants