Improve typesubtract for tuples #35600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Apr 26, 2020
tkf
commented
Apr 26, 2020
Co-Authored-By: Jameson Nash <vtjnash@gmail.com>
mbauman
added a commit
that referenced
this pull request
Apr 28, 2020
* origin/master: (833 commits) Improve typesubtract for tuples (#35600) Make searchsorted*/findnext/findprev return values of keytype (#32978) fix buggy rand(RandomDevice(), Bool) (#35590) remove `Ref` allocation on task switch (#35606) Revert "partr: fix multiqueue resorting stability" (#35589) exclude types with free variables from `type_morespecific` (#35555) fix small typo in NEWS.md (#35611) enable inline allocation of structs with pointers (#34126) SparseArrays: Speed up right-division by diagonal matrices (#35533) Allow hashing 1D OffsetArrays NEWS item for introspection macros (#35594) Special case empty covec-diagonal-vec product (#35557) [GCChecker] fix a few tests by looking through casts Use norm instead of abs in generic lu factorization (#34575) [GCChecker,NFC] run clang-format -style=llvm [GCChecker] fix tests and add Makefile Add introspection macros support for dot syntax (#35522) Specialize `union` for `OneTo` (#35577) add pop!(vector, idx, [default]) (#35513) bump Pkg version (#35584) ...
JeffBezanson
pushed a commit
that referenced
this pull request
Sep 21, 2020
vtjnash
added a commit
that referenced
this pull request
Sep 23, 2020
vtjnash
added a commit
that referenced
this pull request
Sep 23, 2020
vtjnash
added a commit
that referenced
this pull request
Sep 24, 2020
vtjnash
added a commit
that referenced
this pull request
Sep 24, 2020
vtjnash
added a commit
that referenced
this pull request
Sep 24, 2020
Improve typesubtract for tuples (repeat #35600)
KristofferC
pushed a commit
that referenced
this pull request
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
close #35566
Unfortunately, I couldn't construct an example where the performance is improved by this inference yet, even though I can confirm that the methods are correctly inlined as expected.