Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve typesubtract for tuples (repeat #35600) #37714

Merged
merged 5 commits into from
Sep 24, 2020
Merged

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Sep 23, 2020

This re-introduces the improvements #35600—recently reverted—to sharpen the information on Tuple objects through an isa-split (with some improvements of my own towards handling UnionAll over Union), but now limited by the MAX_UNION_SPLITTING parameter to prevent exponential blowup.

@mhauru
Copy link
Contributor

mhauru commented Sep 29, 2020

Would there be a downside to making the MAX_UNION_SPLITTING::Int argument of typesubtract optional, with a sensible default, or maybe with one that reproduces the old behavior? I noticed the change because commit 5a56ecd broke a custom version of @inferred in https://github.com/Jutho/TestExtras.jl, that's calling typesubtract. I guess these are pretty deep internals, and the change is very easy to adapt to, but it still seems like unnecessary breakage to me.

@vtjnash
Copy link
Member Author

vtjnash commented Sep 29, 2020

See af6542e. As you guessed, packages should not rely upon access to Core.Compiler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:inference Type inference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants