Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a possible typo in renumber_ir_elements! #38033

Closed
wants to merge 1 commit into from

Conversation

tkf
Copy link
Member

@tkf tkf commented Oct 15, 2020

#34254 changed

(labelchangemap[end] != 0 && ssachangemap[end] != 0) || return

to

if labelchangemap[end] == 0 && ssachangemap[end] == 0
return
end

If this part was meant to be an NFC, maybe it should be labelchangemap[end] == 0 || ssachangemap[end] == 0 instead? Or was it actually a bug fix?

@tkf tkf requested a review from vtjnash October 15, 2020 04:11
@vtjnash
Copy link
Member

vtjnash commented Oct 15, 2020

It twas intended as a bug fix. May I ask how you noticed this? That commit isn't exactly recent.

@tkf
Copy link
Member Author

tkf commented Oct 15, 2020

Thanks for checking this. I was just playing with Tapir #31086 and your patch was happened to be adjacent to it.

@tkf tkf closed this Oct 15, 2020
@tkf tkf deleted the demorgan branch October 15, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants