Revert "add stream shutdown and support half-duplex operation" #42004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6c4f216.
|
Closing in favor of #42005, which addresses the issues introduced by the PR that this reverts. |
vtjnash
added a commit
that referenced
this pull request
Aug 26, 2021
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
A stream can continue to be read after closewrite, but cannot continue to be written to after seeing EOF. Replaces JuliaLang#42004 Replaces JuliaLang#41983 Fixes JuliaLang#41942 Refs JuliaLang#40783
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
A stream can continue to be read after closewrite, but cannot continue to be written to after seeing EOF. Replaces JuliaLang#42004 Replaces JuliaLang#41983 Fixes JuliaLang#41942 Refs JuliaLang#40783
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #40783
This pull request reverts #40783. #40783 has introduced bugs on at least two platforms:
For FreeBSD x86_64, it breaks the Sockets tests - see #41942 for details.
For Linux x86_64, it has introduced a bug in HTTP.jl in which certain HTTP.jl functions will hang indefinitely. Bisect shows that this PR introduced the bug. Reverting this PR fixes the bug. For details of the bisect, see JuliaLang/BumpStdlibs.jl#53. To see a demonstration of the revert fixing the bug, see JuliaLang/BumpStdlibs.jl#54.
Because two platforms are broken, I think the best course of action is to revert #41942, and then reland a different version with the bugs fixed.