Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streams: disable half-duplex operation support #42005

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Aug 25, 2021

Replaces #42004
Replaces #41983
Fixes #41942
Refs #40783

DilumAluthge added a commit to JuliaLang/BumpStdlibs.jl that referenced this pull request Aug 25, 2021
@DilumAluthge
Copy link
Member

Let's see how JuliaLang/BumpStdlibs.jl#55 fares.

Copy link
Member

@DilumAluthge DilumAluthge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the hangs on Linux x86_64. See e.g. JuliaLang/BumpStdlibs.jl#55

@ararslan
Copy link
Member

Confirmed that this indeed fixes the FreeBSD Sockets tests. (CI has been in sufficiently poor shape that I'm not sure we would have been able to tell without checking manually.) Thanks!

Copy link
Member

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@DilumAluthge DilumAluthge added the merge me PR is reviewed. Merge when all tests are passing label Aug 25, 2021
@JeffBezanson JeffBezanson added the io Involving the I/O subsystem: libuv, read, write, etc. label Aug 25, 2021
@DilumAluthge DilumAluthge reopened this Aug 26, 2021
@vtjnash vtjnash merged commit 24876b7 into master Aug 26, 2021
@vtjnash vtjnash deleted the jn/no-half-duplex branch August 26, 2021 15:41
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Aug 26, 2021
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
A stream can continue to be read after closewrite,
but cannot continue to be written to after seeing EOF.

Replaces JuliaLang#42004
Replaces JuliaLang#41983
Fixes JuliaLang#41942
Refs JuliaLang#40783
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
A stream can continue to be read after closewrite,
but cannot continue to be written to after seeing EOF.

Replaces JuliaLang#42004
Replaces JuliaLang#41983
Fixes JuliaLang#41942
Refs JuliaLang#40783
vtjnash added a commit that referenced this pull request Jul 15, 2022
vtjnash added a commit that referenced this pull request Jul 22, 2022
vtjnash added a commit that referenced this pull request Jul 25, 2022
ffucci pushed a commit to ffucci/julia that referenced this pull request Aug 11, 2022
pcjentsch pushed a commit to pcjentsch/julia that referenced this pull request Aug 18, 2022
KristofferC pushed a commit that referenced this pull request Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
io Involving the I/O subsystem: libuv, read, write, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sockets test fail on FreeBSD 12
4 participants