Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimizer: minor refactor try_compute_fieldidx_expr #42025

Merged
merged 1 commit into from
Aug 28, 2021
Merged

optimizer: minor refactor try_compute_fieldidx_expr #42025

merged 1 commit into from
Aug 28, 2021

Conversation

aviatesk
Copy link
Member

This utility is generally useful for implementing field analysis.
Especially, my motivation is: aviatesk/EscapeAnalysis.jl#43

vtjnash
vtjnash approved these changes Aug 28, 2021
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is use_expr not always an Expr for you (even though it has the structure of a getfield :call)? Anyways, LGTM

@aviatesk
Copy link
Member Author

aviatesk commented Aug 28, 2021 •
edited
Loading

yeah, I wanted this because we're dealing with args::Vector{Any} for builtin handlings under the current implementation of EscapeAnalysis.jl. We can change that, but I think this change is also preferable.

@aviatesk aviatesk merged commit f540501 into master Aug 28, 2021
@aviatesk aviatesk deleted the avi/min branch August 28, 2021 05:34
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@aviatesk @LilithHafner
minor refactor try_compute_fieldidx_expr (JuliaLang#42025)
4277e0d
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@aviatesk @LilithHafner
minor refactor try_compute_fieldidx_expr (JuliaLang#42025)
cb9e0f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aviatesk @vtjnash