CI (Buildkite): in the experimental asan job, remove the "Test that ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step)
#42229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
added
ci
|
Looking at the last 10 failures in the master branch https://buildkite.com/julialang/julia-master-experimental/builds?branch=master it looks like all of them failed on the |
tkf
reviewed
Sep 13, 2021
Co-authored-by: Takafumi Arakaki <aka.tkf@gmail.com>
DilumAluthge
changed the title
asan jobasan job, remove the contrib/asan/check.jl step (but keep the "Build julia-debug with ASAN" step)
|
Let's give that a try. |
DilumAluthge
changed the title
asan job, remove the contrib/asan/check.jl step (but keep the "Build julia-debug with ASAN" step)asan job, remove the "Test that ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step)
84 tasks
95 tasks
This was referenced Oct 3, 2021
66 tasks
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
… ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step) (JuliaLang#42229) Co-authored-by: Takafumi Arakaki <aka.tkf@gmail.com> Co-authored-by: Takafumi Arakaki <aka.tkf@gmail.com>
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
… ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step) (JuliaLang#42229) Co-authored-by: Takafumi Arakaki <aka.tkf@gmail.com> Co-authored-by: Takafumi Arakaki <aka.tkf@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Of the 20 most recent
julia-master-experimentaljobs on themasterbranch, 7 have passed and 13 have failed.I don't think it's particularly useful to keep running a job that is this flaky. I would propose that we disable the
asanjob for now. Once we figure out how to get it to reliably pass, we can consider re-enabling it.